As the classes in twitter.lib.php are included automatically by Drupal core (because the file is declared in twitter.info) we don't need to do an explicit include anymore.

This patch removes that includes.

CommentFileSizeAuthor
twitter_remove_includes.patch3.15 KBjose reyero

Comments

jose reyero’s picture

jose reyero commented
Status: Active » Needs review
juampynr’s picture

juampynr commented
Status: Needs review » Fixed

I did that at http://drupalcode.org/project/twitter.git/commitdiff/27e1088c45a46945862..., but it was because I added the library at the top of twitter.module. I did not realize this when I ported the patch from Drupal 6 to Drupal 7.

I have removed the module_load_include() call at http://drupalcode.org/project/twitter.git/commitdiff/32abb809d61917d0aad....

Many thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented

These changes cause a fatal PHP error. See #1360936: Fatal error: Class 'TwitterConf' not found