I ran ckeditor module through coder, it picked up several warnings, and a ton of notices.

CommentFileSizeAuthor
#1 ckeditor-1347352.patch349.46 KBsweetchuck

Comments

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented
Status: Active » Needs work
StatusFileSize
new ckeditor-1347352.patch349.46 KB

Quick fix for PHP files, but the JS files are remains in different style.

mkesicki’s picture

mkesicki commented
Status: Needs work » Postponed

Thx for your patch. We will use coder in future version to make some cleanup in code.

balintbrews’s picture

balintbrews
he/him/his
Primary language Hungarian
Location Netherlands 🇪🇺
commented

Great job by Sweetchuck, the module needs a serious code cleanup. May I ask why is this postponed?

mkesicki’s picture

mkesicki commented

@balintk we will make cleanup and use of this patch in future versions, so this is the reason why ticket is postponed.
@Sweetchuck thank you again, the patch looks fine.

sweetchuck’s picture

sweetchuck
Primary language Hungarian
Location Budapest
commented

OK, Thank you :-)