Supersubs makes it possible to define custom widths for your menus. Function does not work(((

Privet Igor,

Looks like the JavaScript is not running at all, do you see any error message in the "Console" tab of the Firebug? well in case you're not using it, install Firefox and then install Firebug on it.

I don't know much Russian either :) I found it, it's not the JavaScript, it's the Supersubs plugin not working right for some reasons; Increase the Minimum width to 12 or 14 and it'll look good again.

Two things:

1. Please upgrade to v1.8 or v1.9-beta4 because v1.9-beta2 is in fact v1.7 .
2. On your website, with beta2, you have 13 and 15 as minimum and maximum widths, look:
   

   "supersubs": { "minWidth": "13", "maxWidth": "15", "extraWidth": 1 }
   

   v1.9-beta4 and v1.8 will work too, if you use the same settings (13 and 15) instead of 5 and 14 (your 2.png).

In the next version of the Superfish library, yes it'll be fixed.

That one is not important. :)

Spasibo Igor :)

Da, the supersubs.js, however it's not a big deal. The job of the Supersubs is resizing each sub-menu based on the width of its widest menu item, therefore all the items of the sub-menu will appear in 1 line and not wrapped into more than one line, of course as long as the new width is not bigger than the Maximum width and not smaller than the Minimum width).

From what I see currently, the Supersubs is not doing that, instead of that, it is resizing all of the sub-menus to fit the Minimum width, I don't know the reason, but the issue is in my to-do list and it'll be fixed as soon as possible.

Any progress with this?

I took a closer look at this and it seems that the supersubs plugin fails to calculate the item widths (clientWidth js attribute) because the display attribute of the parent UL tag has been set to "none" by a call to hideSuperfishUl() at line 50 of the superfish.js (in the librairies directory not the module directory).

In earlier versions of this module the supersubs function is called prior to the superfish main function whereas in the current beta4 the order is reversed. Consquently the superfish menu is already hidden by the time the supersubs goes to work.

Just read the supersubs doc page where it states

Note that Supersubs needs to be called before Superfish in the initialisation chain

So, there are a couple of solutions to this issue in the latest beta of this module:

a) rework the logic in modules/superfish/superfish.js so that supersubs gets to calculate the menu widths before the display is hidden by the main superfish function:

(function ($) {
  /**
   * The Superfish Drupal Behavior to apply the Superfish jQuery plugin to lists.
   */
  Drupal.behaviors.superfish = function (context) {
    // Take a look at each list to apply Superfish to.
    $.each(Drupal.settings.superfish || {}, function(index, options) {
      // Process all Superfish lists.
      var  list = $('#superfish-' + options.id, context);
      // Apply Superfish to the list.
      list.superfish(options.sf);

      // Check if we are to apply any plugins to it.
      if (options.plugins || false) {
        if (options.plugins.touchscreen || false) {
          list.sftouchscreen();
        }
        if (options.plugins.supposition || false) {
          list.supposition();
        }
        if (options.plugins.bgiframe || false) {
          list.find('ul').bgIframe({opacity:false});
        }
        if (options.plugins.supersubs || false) {
          list.supersubs(options.plugins.supersubs); // <-- move this ahead of superfish function
        }
      }
    });
  };
}(jQuery));

b) add a line to the supersubs.js function to make any hidden menu items visible and there available for width calculation

        // remove width restrictions and floats so elements remain vertically stacked
        var emWidth = $ul.add($LIs).add($As).css({
          'float' : 'none',
          'width'  : 'auto',
          'display' : 'block' // <-- add this line to temporarily give the menu item visibility so the width can be calculated
        })
        // this ul will now be shrink-wrapped to longest li due to position:absolute
        // so save its width as ems. Clientwidth is 2 times faster than .width() - thanks Dan Switzer
        .end().end()[0].clientWidth / fontsize;

It looks like option a) is preferable since it doesn't impact the underlying superfish libarary. I'm just not sure how to do it.

Here is a patch which addresses the solution (option a) I proposed above to rework the logic in modules/superfish/superfish.js so that supersubs gets to calculate the menu widths before the display is hidden by the main superfish function.

Hey eft,

Thank you very much, will review it as soon as possible!

:)

Here is a cleaner version of the patch

Mehrpadin,

Any chance of a review of this patch?

tx

I just reviewed this patch. Applied it to 7.x-1.9-beta4. No change, Supersubs always re-sizes the UL to the specified minimum with no regard for the length of the text in the menu. Yes, I verified that the updated JS is being loaded by the browser through Chrome dev tools.

The patch didn't work for me. As in I couldn't even apply it.

patching file `superfish.js'
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 28.
2 out of 2 hunks FAILED -- saving rejects to superfish.js.rej

I put the patch in the superfish module directory then ran:

patch -p0 < superfish-fix-supersubs-1347710-14_0.patch

Any suggestions?

Cheers.

Same here.

- Installed superfish 7.x-1.9-beta4
- went into the module directory. superfish.js is present
- downloaded patch #16

#patch  < superfish-fix-supersubs-1347710-14_0.patch 
patching file superfish.js
Hunk #1 FAILED at 7.
Hunk #2 FAILED at 28.
2 out of 2 hunks FAILED -- saving rejects to file superfish.js.rej

# more superfish.js.rej 
***************
*** 7,12 ****
      $.each(Drupal.settings.superfish || {}, function(index, options) {
        // Process all Superfish lists.
        var  list = $('#superfish-' + options.id, context);
        // Apply Superfish to the list.
        list.superfish(options.sf);
  
--- 7,19 ----
      $.each(Drupal.settings.superfish || {}, function(index, options) {
        // Process all Superfish lists.
        var  list = $('#superfish-' + options.id, context);
+ 
+       // apply supersubs first so that subs are not display:none when measurin
g
+       // (see http://users.tpg.com.au/j_birch/plugins/superfish/#sample5)
+       if (options.plugins.supersubs || false) {
+         list.supersubs(options.plugins.supersubs);
+       }
+ 
        // Apply Superfish to the list.
        list.superfish(options.sf);
  
***************
*** 21,30 ****
          if (options.plugins.bgiframe || false) {
            list.find('ul').bgIframe({opacity:false});
          }
-         if (options.plugins.supersubs || false) {
-           list.supersubs(options.plugins.supersubs);
-         }
        }
      });
    };
- }(jQuery));--- 28,34 ----
          if (options.plugins.bgiframe || false) {
            list.find('ul').bgIframe({opacity:false});
          }
        }
      });
    };
+ }(jQuery));

by the way on my installation (with Acquia Marina) the width of the vertical menu stays stuck at the number hard-coded in the superfish library css "superfish-vertical.css" which I've had to increase from 12em to 18em. What I put in the GUI in the supersubs area is simply ignored.

.sf-vertical,
.sf-vertical li {
  width: 18em;
}
.sf-vertical li:hover > ul,
.sf-vertical li.sfHover > ul {
  left: 18em;
  top: 0;
}

thanks

By the way, my comments #20 and #21 apply to version 7.x-1.9-beta4 and I see that the version indicated in this issue is 6.x-1.9-beta3.

Should I open a new issue for 7.x ? Is that why the patch in #16 doesn't apply ?

Thanks !

eft, which version of the superfish module is this #16 patch for ? Thanks !!

i'm also running v7.x-1.9-beta4 (with Drupal 7 and Omega 3) and not getting supersubs to work -- looks like it's just rendering min width -- is there a patch for 7.x?

Need a fix also here.

Hey everybody,

I do apologies, I'm still terribly busy, can't get to SF & git yet, for the time being, you can put the attached ones in /sites/modules/superfish .

:)

Correction: /sites/all/modules/superfish

:)

#26 works like a charm.. this was driving me mad! Must be related to Omega (or just media queries in general) and bases it on the smallest layout, and doesn't update when you resize or when it loads the others.

Ok wait, scratch that, it doesn't work at all. it does nothing when I put it in sites/all/modules/superfish. The reason I thought it was working was because I thought it was to replace libraries/superfish/superfish.js and had done that... when I realized that had caused errors I started looking about and yeah, something's definitely amiss. Did I misunderstand how to implement?

So, for help troubleshooting, here are some details:
I am using Omega. Even if I have only a fixed-width layout enabled, I believe there is still a conflict/issue.
It is almost as if it grabs it from the smallest layout, regardless of which you are in.
It does not update on resize.
For some reason, supersubs was working when I replaced my libraries/superfish/superfish.js file with the one provided above.
But, that causes an error because there is no method 'superfish'.
And it also does nothing if i just paste that at the end of the existing superfish.js

I also tried #26 for d7 and it didn't work for me either. I'm using Adaptive Themes - Sky theme.

Mickey

Fixed in the development release :)