Closed (fixed)
Project:
Code per Views Display
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
21 Nov 2011 at 04:16 UTC
Updated:
26 Sep 2012 at 02:51 UTC
Jump to comment: Most recent file
Comments
Comment #1
JamesAn commentedOops. I didn't run the module code with E_STRICT set. That shouldn't happen and the fix should be easy. I'll get it patched tomorrow.
Comment #2
JamesAn commentedApparently, this is a Views bug. #1281698: PHP strict warning: Declaration of views_plugins_display_extender::option_definition() does not match its parent class
Comment #3
chi commentedOk let's close this.
Comment #4
IWasBornToWin commentedAccording to views, it's not, see http://drupal.org/node/1467946#comment-5698164
I am going in circles :)
Comment #5
IWasBornToWin commentedI'm reopening this. As it isn't solved according to views. Please see this latest comment with specific coding suggestions;
http://drupal.org/node/1467946#comment-5700434
Comment #6
int_ua commentedComment #7
int_ua commentedComment #8
int_ua commentedComment #9
int_ua commented#6 patch gives
Comment #10
int_ua commentedComment #11
chi commentedJust made it like views default extanders
Comment #12
IWasBornToWin commentedI just applied this patch and recieved these warnings:
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_css in cpv_plugin_display_extender_code->pre_execute() (line 31 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Comment #13
JamesAn commentedI've updated the dev version with a fix.
The code was changed to implement option_definition_alter() instead of option_definition() and pre_execute() checks for the existence of the css and js strings before using them to avoid addressing an undefined index, when either the css or js strings are empty (i.e. they don't exist).
If you can confirm this eliminates the warning messages, I'll mark this as fixed.
Comment #14
IWasBornToWin commentedWhere is the "updated" dev version? I see two versions, both dated back to 11/2011.
Comment #15
JamesAn commentedApparently, dev releases are only updated every 12 hours: http://drupal.org/node/289662.
I've attached a patch that will bring the current dev snapshot made on November 16, 2011 up to the current committed code.
Comment #16
philvinall commentedI can confirm the dev release solves a similar issue for me. Thanks very much. Great module by the way - very much appreciated.
Comment #17
JamesAn commentedAwesome! Marked as fixed then. Hurray!
Comment #18.0
(not verified) commentedEddit error message