I got this warning after enabling the cpv module.
Strict warning: Declaration of cpv_plugin_display_extender_code::option_definition() should be compatible with that of views_object::option_definition() in require_once() (line 12 of www/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
I am using php 5.3.

Comments

JamesAn’s picture

Assigned: Unassigned » JamesAn

Oops. I didn't run the module code with E_STRICT set. That shouldn't happen and the fix should be easy. I'll get it patched tomorrow.

JamesAn’s picture

chi’s picture

Status: Postponed » Closed (duplicate)

Ok let's close this.

IWasBornToWin’s picture

According to views, it's not, see http://drupal.org/node/1467946#comment-5698164

I am going in circles :)

IWasBornToWin’s picture

Status: Closed (duplicate) » Active

I'm reopening this. As it isn't solved according to views. Please see this latest comment with specific coding suggestions;

http://drupal.org/node/1467946#comment-5700434

int_ua’s picture

Assigned: JamesAn » int_ua
Status: Active » Patch (to be ported)
StatusFileSize
new475 bytes
int_ua’s picture

Status: Patch (to be ported) » Needs review
int_ua’s picture

Assigned: int_ua » Unassigned
int_ua’s picture

#6 patch gives

Notice: Undefined index: cpv_css in cpv_plugin_display_extender_code->pre_execute() (line 29 of sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 30 of sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).

int_ua’s picture

Status: Needs review » Active
chi’s picture

Status: Active » Needs review
StatusFileSize
new630 bytes

Just made it like views default extanders

IWasBornToWin’s picture

I just applied this patch and recieved these warnings:

Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_css in cpv_plugin_display_extender_code->pre_execute() (line 31 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).
Notice: Undefined index: cpv_js in cpv_plugin_display_extender_code->pre_execute() (line 32 of /home4/growtogi/public_html/sites/all/modules/cpv/cpv_plugin_display_extender_code.inc).

JamesAn’s picture

I've updated the dev version with a fix.

The code was changed to implement option_definition_alter() instead of option_definition() and pre_execute() checks for the existence of the css and js strings before using them to avoid addressing an undefined index, when either the css or js strings are empty (i.e. they don't exist).

If you can confirm this eliminates the warning messages, I'll mark this as fixed.

IWasBornToWin’s picture

Where is the "updated" dev version? I see two versions, both dated back to 11/2011.

JamesAn’s picture

StatusFileSize
new1.55 KB

Apparently, dev releases are only updated every 12 hours: http://drupal.org/node/289662.

I've attached a patch that will bring the current dev snapshot made on November 16, 2011 up to the current committed code.

philvinall’s picture

I can confirm the dev release solves a similar issue for me. Thanks very much. Great module by the way - very much appreciated.

JamesAn’s picture

Status: Needs review » Fixed

Awesome! Marked as fixed then. Hurray!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

Issue summary: View changes

Eddit error message