Issue 13447 complains rightfully that the /glossary page can be somewhat unclear. I think this is mostly caused by listing all vocabularies, instead of only those used as glossary by an input filter.

The attached patch solves this.

It also makes viewing glossary overviews (/glossary/VID) possible only for glossary taxonomies

Please review.

Thanks,
  Frodo

CommentFileSizeAuthor
only-used-vids.patch2.13 KBFrodo Looijaard

Comments

slower’s picture

slower commented

Very nice. I was going to hack this in myself. Works as expected on my 4.5 system. Nearly perfects an already great module.

I still think there ought to be a variable on the admin page for limiting the output of characters in the tooltips for glossary terms. As I said in issue 13134, my site uses the glossary somewhat loosely and defines some terms in great detail, making for extremely unwieldy tooltips. I'll submit a patch this week to illustrate. But I digress.

slower’s picture

slower commented

Side note: if I am to submit a patch, which version of glossary.module do I start with? The vanilla 4.5 release, no patches applied?

moshe weitzman’s picture

moshe weitzman commented

this patch looks good. please commit.

fyi - patches should always be taken against HEAD.

Frodo Looijaard’s picture

Frodo Looijaard commented

Committed to HEAD and DRUPAL-4-5

Anonymous’s picture

(not verified) commented