Download & Extend
Zen » Issues

Convert breadcrumb markup to HTML5

Posted by JohnAlbin on November 21, 2011 at 9:33am
Project:Zen
Version:7.x-5.x-dev
Component:layout.css
Category:task
Priority:normal
Assigned:Unassigned
Status:closed (fixed)

Issue Summary

The markup around the breadcrumb needs to be updated for HTML5. We should try to follow what's going on in D8 core.

See #1347266: Convert theme_breadcrumb() to HTML5

Login or register to post comments

Comments

#1

Posted by JohnAlbin on November 21, 2011 at 11:50am
Title:Convert breadcrumb to HTML» Convert breadcrumb markup to HTML
Status:active» fixed

Fixed. http://drupalcode.org/project/zen.git/commitdiff/261a11a

#2

Posted by JohnAlbin on November 21, 2011 at 11:50am
Status:fixed» postponed

We'll still need to track #1347266: Convert theme_breadcrumb() to HTML5 to see if the final patch changes the markup.

#3

Posted by JohnAlbin on December 6, 2011 at 6:07pm
Title:Convert breadcrumb markup to HTML» Convert breadcrumb markup to HTML5

Not sure how I missed the 5 on the end of the issue title. :-p

#4

Posted by maartenverbaarschot on December 20, 2011 at 2:00pm
Status:postponed» needs review

It became an <ol> :)

AttachmentSize
zen5-breadcrumb-4.patch 747 bytes

#5

Posted by JohnAlbin on December 20, 2011 at 7:57pm
Status:needs review» fixed

Yep. Just noticed that.

Thanks, Maarten! You've got a commit now. :-) http://drupal.org/user/1305466

#6

Posted by echoz on December 20, 2011 at 8:13pm
Status:fixed» needs review

..and the css

AttachmentSize
zen5-breadcrumb-6.patch 665 bytes

#7

Posted by JohnAlbin on February 15, 2012 at 6:06am
Component:CSS/HTML markup» layout.css
Status:needs review» fixed

Thanks, Elly!

Fixed. http://drupalcode.org/project/zen.git/commitdiff/66049a8

#8

Posted by System Message on February 29, 2012 at 6:10am
Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here