The markup around the breadcrumb needs to be updated for HTML5. We should try to follow what's going on in D8 core.

See #1347266: Convert theme_breadcrumb() to HTML5

CommentFileSizeAuthor
#6 zen5-breadcrumb-6.patch665 bytesechoz
#4 zen5-breadcrumb-4.patch747 bytesmaartenverbaarschot

Comments

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Convert breadcrumb to HTML » Convert breadcrumb markup to HTML
Status: Active » Fixed

Fixed. http://drupalcode.org/project/zen.git/commitdiff/261a11a

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Fixed » Postponed

We'll still need to track #1347266: Convert theme_breadcrumb() to HTML5 to see if the final patch changes the markup.

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Title: Convert breadcrumb markup to HTML » Convert breadcrumb markup to HTML5

Not sure how I missed the 5 on the end of the issue title. :-p

maartenverbaarschot’s picture

maartenverbaarschot commented
Status: Postponed » Needs review
StatusFileSize
new zen5-breadcrumb-4.patch747 bytes

It became an <ol> :)

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Status: Needs review » Fixed

Yep. Just noticed that.

Thanks, Maarten! You've got a commit now. :-) http://drupal.org/user/1305466

echoz’s picture

echoz commented
Status: Fixed » Needs review
StatusFileSize
new zen5-breadcrumb-6.patch665 bytes

..and the css

johnalbin’s picture

johnalbin
they/他
Primary language English
Location Taipei, Taiwan
commented
Component: CSS/HTML markup » layout.css
Status: Needs review » Fixed

Thanks, Elly!

Fixed. http://drupalcode.org/project/zen.git/commitdiff/66049a8

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.