Reduce cron watchdog noise (show ad counts only when changed.)

grateful_drupal_user - April 9, 2007 - 18:32
Project:Text Link Ads Integration
Version:4.7.x-1.x-dev
Component:Code
Category:feature request
Priority:minor
Assigned:grateful_drupal_user
Status:needs review
Description

Currently, the update process inserts a count of ads found into the watchdog log on every cron run, even if the number of ads don't change from the last cron run. This creates a lot of noise in the watchdog list. (Yes, it was my code that created this issue... :D )

I propose that we show the ad count only when it changes.

I've attached a proposed patch. Please review and comment.

AttachmentSize
textlinkads-reduce-watchdog-noise.patch1.58 KB

#1

greggles - October 3, 2007 - 17:12

This seems like a reasonably change. I didn't test it, but it seems good to me.

#2

grateful_drupal_user - October 3, 2007 - 18:14

I've been using this patch on my site for a long time (at least, up till the time I gave TLA the boot). It really helps cut the log noise.

 
 

Drupal is a registered trademark of Dries Buytaert.