Is there anyone working on a Drupal 7 port for this module?

CommentFileSizeAuthor
#13 multiple_node_menu.png111.09 KBdman
#4 1348878.patch35.32 KBrecidive
#4 multiple_node_menu_7.x.tar_.gz5.11 KBrecidive
#4 1348878.png53.24 KBrecidive

Comments

recidive’s picture

recidive commented
Title: Drupal 7 Port? » Drupal 7 Port
Assigned: Unassigned » recidive

Ok, I started working on this, should post a patch soon.

ipwa’s picture

ipwa commented

Hey Henrique, we need this for a project on a project I'm working on, and we would like to help this module get a D7 release. So we don't duplicate any of your work, can you please post your patch with the work so far, so we can start working on it from that point onwards. Cheers.

recidive’s picture

recidive commented

@ipwa: hello, we got a complete port of Multiple Node Menu including simpletests. It turned out to be an almost complete refactoring of the module.

We should be posting a patch here soon. Stay tuned.

recidive’s picture

recidive commented
Status: Active » Needs review
StatusFileSize
new 1348878.png53.24 KB
new multiple_node_menu_7.x.tar_.gz5.11 KB
new 1348878.patch35.32 KB

Here is a port for the Multiple Node Menu module. This is not a straight port, due to drastic changes in Drupal 7, it made more sense to start from scratch, and copy the parts that we could reuse. The patch also adds some simpletests.

A tarball withe the ported module and a screenshot of the UI are attached too.

recidive’s picture

recidive commented

@ipwa: have you got the chance to test the patch?

Any chance we can get this committed to a 7.x branch?

hershel’s picture

hershel commented

Empirically speaking, this module is working for me in D7.

Well, aside from the fact that with one or even two menu items for a node, it still says "Not in menu" under "Menu settings" when I edit the node.

Thank you. :)

glenn_jones’s picture

glenn_jones commented

Hi guys,

Thanks for this great module. You have no idea how this module could solve complex problems.

Only... A port to Drupal 7 would be very useful.

Any idea when you would get this done?

Thx on front,

Glenn

hershel’s picture

hershel commented

Glenn_Jones, try the code above in comment #4. It works for me.

recidive’s picture

recidive commented

Hey guys, can we move this to RTBC and get this committed to the 7.x-1.x branch?

skwashd’s picture

skwashd commented
Status: Needs review » Reviewed & tested by the community

We already have this in pre launch testing for a client.

Once a 7.x-1.x branch is opened any issues can be opened against the branch.

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented

+1 for reviewed - do you want a co-maintainer?

mareks’s picture

mareks commented

seems to work for me for now. will let you know if it fails.

dman’s picture

dman commented
StatusFileSize
new multiple_node_menu.png111.09 KB

Yeah this is working enough for a d7 branch.
Small Issue I found in #4 - the vertical tab shows "Not in menu" even when it is.

testtest23112’s picture

testtest23112 commented

@recidive, thank you very much for your work!
This module is exactly what I wanted. I'm surprised that such functionality isn't build-in in Drupal's core. For example, how else can I quickly create a menu with featured links from the main menu? This module helps.

recidive’s picture

recidive commented

Hello guys,

thanks for testing. I don't have time right now to fix the "not in menu bug" described in #6 and #13, so if any of you can, please amend the patch to cover that.

I've just contacted PeteS the maintainer asking him to weigh in.

opdavies’s picture

opdavies
He/him
Primary language English
Location Wales
commented

#4 works for me, although the patch wouldn't apply.

The next patch would delete the file includes/multiple_node_menu.admin.inc,
which does not exist!

piratawww’s picture

piratawww commented

Pls, commit this to a 7.x-1.x branch... It works great. Thx

dman’s picture

dman commented

Can we get a release published? at least for download from the project page? A -dev would be fine.
Thanks.

recidive’s picture

recidive commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

I've taken over module maintainership. Committed the patch in #4, and tagged a 1.0-beta1 release. Also filed the "Not in menu bug" as described by @dman in #13: #1532296: Menu settings shows "Not in menu" even when there are menu items. Development is now open again. Thanks for the reviews guys,

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.