Currently, our event creation form looks like:

Per Noyz's suggestion in https://docs.google.com/a/acquia.com/document/d/1IqS5vuKsSv0cDwk0vZGxgBM..., it should look more like:

Here's a patch that re-arranges fields per the comp, minus CSS style changes, so that the form looks like:

CommentFileSizeAuthor
#4 1348920-4.patch1.98 KBezra-g
#3 commons-tweak-event-form-3.patch2.82 KBlaurentc
#2 commons-tweak-event-form-2.patch3.14 KBlaurentc
commons-tweak-event-form.patch25.28 KBezra-g

Comments

ezra-g’s picture

ezra-g commented
Status: Needs review » Fixed

Laurentc provided a review in a direct communication. This is committed: http://drupalcode.org/project/commons.git/commit/29c95b9

laurentc’s picture

laurentc commented
Status: Fixed » Needs review
StatusFileSize
new commons-tweak-event-form-2.patch3.14 KB

I'm re-opening the issue as the patch is causing side effects on vertical tabs.
Here is a new patch to fix the problem.

Thanks.

laurentc’s picture

laurentc commented
StatusFileSize
new commons-tweak-event-form-3.patch2.82 KB

Patch update. Same as previous one but also moves og options out of vertical tabs.

ezra-g’s picture

ezra-g commented
StatusFileSize
new 1348920-4.patch1.98 KB

Here's an alternative approach per #654604: add hook_vertical_tabs_alter to control tab configuration that avoids adding an installation setup task and persists in code.

This preserves improvements that were the initial motivation of this issue while also removing the main OG fieldsets from vertical tabs on the group creation form.

laurentc’s picture

laurentc commented

It looks good. Can you commit?

Thanks,

laurentc’s picture

laurentc commented
Status: Needs review » Reviewed & tested by the community
ezra-g’s picture

ezra-g commented
Status: Reviewed & tested by the community » Fixed

http://drupalcode.org/project/commons.git/commit/2f9aab1

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.