views_mosaic

Review of the 7.x-1.x branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/views_mosaic.module:
   +3: [minor] @file description should be on the following line
   +11: [normal] Use an indent of 2 spaces, with no tabs
   +12: [normal] Use an indent of 2 spaces, with no tabs
   +13: [normal] Use an indent of 2 spaces, with no tabs
   +39: [normal] Use an indent of 2 spaces, with no tabs
   +39: [normal] missing space after comma
   +39: [minor] There should be no trailing spaces
   +43: [minor] Use an indent of 2 spaces, with no tabs
   +45: [minor] There should be no trailing spaces
  
  Status Messages:
   Coder found 1 projects, 1 files, 5 normal warnings, 4 minor warnings, 0 warnings were flagged to be ignored
  

• README.txt is missing, see the guidelines for in-project documentation.
• The "?>" PHP delimiter at the end of files is discouraged, see http://drupal.org/node/318#phptags
  

  ./views_mosaic.views.inc
  

• ./theme/views_mosaic.theme.inc: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
  

  	      // old templates from producing invalid HTML when no element type is selected.
  

• Comments should be on a separate line before the code line, see http://drupal.org/node/1354#inline
  

  ./views_mosaic.module:32:   'row' => array( //declare the unformatted row plugin
  ./theme/views_mosaic.theme.inc:56:	        $object->raw = NULL; // make sure it exists to reduce NOTICE
  ./includes/mosaic.jquery.js:109:        overlay  	: '.mosaic-overlay',	//Mosaic overlay
  ./includes/mosaic.jquery.js:110:		backdrop 	: '.mosaic-backdrop'	//Mosaic backdrop
  

• There should be no space after the opening "(" of an array, see http://drupal.org/node/318#array
  

  views_mosaic.module:32:   'row' => array( //declare the unformatted row plugin
  

• Classes and Interfaces should use UpperCamel naming. See http://drupal.org/node/608152
  

  ./views_mosaic.views.inc:6:class views_plugin_row_views_mosaic extends views_plugin_row_fields {
  

• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./theme/views_mosaic.theme.inc ./theme/views-view-row-mosaic.tpl.php ./views_mosaic.js ./views_mosaic.views.inc ./views_mosaic.info ./views_mosaic.css ./includes/mosaic.jquery.js
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Review of the 7.x-1.x branch:

• Run coder to check your style, some issues were found (please check the Drupal coding standards):
  

  Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
  
  sites/all/modules/pareview_temp/test_candidate/views_mosaic.module:
   +3: [minor] @file description should be on the following line
  
  Status Messages:
   Coder found 1 projects, 1 files, 1 minor warnings, 0 warnings were flagged to be ignored
  

• Lines in README.txt should not exceed 80 characters, see the guidelines for in-project documentation.
• ./theme/views_mosaic.theme.inc: comment lines should break at 80 characters, see http://drupal.org/node/1354#general
  

        // old templates from producing invalid HTML when no element type is selected.
  

• Comments should be on a separate line before the code line, see http://drupal.org/node/1354#inline
  

  ./includes/mosaic.jquery.js:109:        overlay  	: '.mosaic-overlay',	//Mosaic overlay
  ./includes/mosaic.jquery.js:110:		backdrop 	: '.mosaic-backdrop'	//Mosaic backdrop
  

• views_mosaic.module in views_mosaic.info: It's only necessary to declare files[] if they declare a class or interface.
• Classes and Interfaces should use UpperCamel naming. See http://drupal.org/node/608152
  

  ./views_mosaic.views.inc:7:class views_plugin_row_views_mosaic extends views_plugin_row_fields {
  

• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./views_mosaic.module ./theme/views_mosaic.theme.inc ./theme/views-view-row-mosaic.tpl.php ./views_mosaic.js ./README.txt ./views_mosaic.views.inc ./views_mosaic.info ./views_mosaic.css ./includes/mosaic.jquery.js
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Dont forget to change the status to needs review once you do the changes.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

manual review:

• mosaic.jquery.js: appears to be 3rd party code. 3rd party code is not generally allowed on Drupal.org and should be deleted. This policy is described in the getting involved handbook. It also appears in the terms and conditions you agreed to when you signed up for Git access, which you may want to re-read, to be sure you're not violating other terms. The Libraries API module is a recommended method for adding 3rd party dependencies without directly including the code on Drupal.org.
• views_mosaic_init(): are you sure that you need you CSS and javascript on literally every page? Please search for a way to include this if an actual mosaic view is displayed.
• views_mosaic_views_api(): remove the "alpha" from the API version.
• views_plugin_row_views_mosaic: yes you should camel case your own class names, even if Views does it wrong.
• "//@TODO: make it better": what exactly needs to be improved? Please add a more verbose comment.
• views_mosaic.css: formatting errors, please see the CSS coding standards: http://drupal.org/node/302199

@rafaelcaceres has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

Any news on this?

I close this one since the applicant has not responded, @rafaelcaceres, if this is wrong, please reopen.

Indeed. any news? I'd love this module. Any other similar to this already?

Well I got the sandbox files, and really like this. Obviously there are some additions that would be nice (ie. better control for setting anchor sides, ability to change caption BG color thru view format settings, etc), but most of all, I hope that you pick this project back up and get it promoted to full "project"

Hey Rafael!

Already reviewed by me and I think is ready for a release now :)

Thanks to all who helped to make this awesome module possible!

Cheers,
Sebas.

sebas5384: you can not mark a application as RTBC when you are one of the maintainers. And why have you released it as a full project before the application is finished?

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

making description better