This module allows using Yandex.Server as a search engine on a website managed with Drupal. Yandex.Server is built on the same technologies, which are used by Yandex for Internet searching.

This module defines the new "Yandex Server" search type. The data intended for indexing is dumped as HTML files automatically. The contents of these files can be arbitrarily generated using Drupal API. This data can be supplied with metainformation, which can be used in search queries and at search results page forming.

Sandbox project page: http://drupal.org/sandbox/Mir/1343080
Link to Git repository: git clone --branch master git.drupal.org:sandbox/Mir/1343080.git
Live Demo: http://ustroit.ru

CommentFileSizeAuthor
#8 drupalcs-result.txt9.75 KBklausi
yserver.png45.31 KBMir

Comments

chakrapani’s picture

Status: Needs review » Needs work

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

  • Run coder to check your style, some issues were found (please check the Drupal coding standards):
    Severity minor, Drupal Commenting Standards, Internationalization, Drupal Security Checks, Drupal SQL Standards, Drupal Coding Standards
    
    sites/all/modules/pareview_temp/test_candidate/yserver.module:
     +14: [minor] Comment should be read "Implements hook_foo()."
     +75: [minor] Use an indent of 2 spaces, with no tabs
     +164: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
     +172: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
     +243: [minor] Use an indent of 2 spaces, with no tabs
     +248: [minor] Comment should be read "Implements hook_foo()."
     +269: [minor] in most cases, replace the string function with the drupal_ equivalent string functions
    
    Status Messages:
     Coder found 1 projects, 1 files, 7 minor warnings, 0 warnings were flagged to be ignored
    
  • Lines in README.txt should not exceed 80 characters, see the guidelines for in-project documentation.
  • yserver.collection_cfg.inc in yserver.info: It's only necessary to declare files[] if they declare a class or interface.
  • yserver.dump.inc in yserver.info: It's only necessary to declare files[] if they declare a class or interface.
  • yserver.search.inc in yserver.info: It's only necessary to declare files[] if they declare a class or interface.
  • yserver.set_areas.inc in yserver.info: It's only necessary to declare files[] if they declare a class or interface.
  • ./yserver.dump.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
    function _add_html_suffix($str) {
    
  • ./yserver.search.inc: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
    function ustroit_search_get_keys() {
    
  • ./yserver.set_areas.inc: The description on the line after the @param/@return documentation is either missing or not formatted correctly. See http://drupal.org/node/1354#functions
    55- */
    100- */
    141- */
    
  • ./yserver.dump.inc: The description on the line after the @param/@return documentation is either missing or not formatted correctly. See http://drupal.org/node/1354#functions
    470- */
    
  • ./yserver.collection_cfg.inc: The description on the line after the @param/@return documentation is either missing or not formatted correctly. See http://drupal.org/node/1354#functions
    13- */
    
  • ./yserver.search.inc: The description on the line after the @param/@return documentation is either missing or not formatted correctly. See http://drupal.org/node/1354#functions
    95- */
    
  • Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
    ./README.txt:                 UTF-8 Unicode English text, with CRLF line terminators
    ./configs/collection.cfg:     UTF-8 Unicode English text, with CRLF line terminators
    README.txt
    configs/collection.cfg
    
  • All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
    ./yserver.module ./yserver.set_areas.inc ./README.txt ./yserver.info ./yserver.install ./yserver.collection_cfg.inc
    

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Mir’s picture

Dear R Chakrapani, thank you very much for the review.

I've rechecked module in "minor (most)" mode of Coder as well as with help of PAReview script and fixed all errors. Also I've switched from master to a version specific branch 7.x-1.x and remove master branch content as it is suggested.

djg_tram’s picture

Change the status to "needs review", it won't go on without that.

Mir’s picture

Status: Needs work » Needs review

Thanks. Done.

patrickd’s picture

Mir’s picture

Perfect online checker! Thanks a lot.
Fixed: http://ventral.org/pareview/httpgitdrupalorgsandboxmir1343080git

Mir’s picture

Status: Needs work » Needs review
klausi’s picture

Status: Needs review » Needs work
StatusFileSize
new9.75 KB

Review of the 7.x-1.x branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

manual review:

  • There are some false positives thrown by coder and drupalcs, e.g. in the txt files.
  • Are you sure that you need cURL and cannot use drupal_http_request()?
  • yserver_install(): no need to use variable_set() calls here, you can use default values with variable_get anyway.
  • yserver.module: why do you always include the other *.inc files? Do they contain hook implementations? If no, then include them when you actually need them, and not everytime your module file is read (e.g. on literally every page request.)
  • yserver_init(): why do you need hook_init()? This is also executed on every page request, but it seems to do something with nodes and users?
  • The menu path "yserver-dump" seems to be unprotected, are you sure that anyone should be able to call that page callback?
  • "drupal_get_path('module', 'node') . '/../../') . '/yserver')": what is this? Are you trying to get the drupal root directory? Why don't you use the DRUPAL_ROOT constant?
  • Why is your workdir per default in the drupal root and not in the files folder of the respective site? I think This could cause problems for multi site installations right now.
misc’s picture

@Mir has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

misc’s picture

Status: Needs work » Closed (won't fix)

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact