Thank you, this module is awesome! It's by far the best JS cropping widget I've tried so far. And I've tried a lot of them :-). Together with Insert, this would basically provide a simple but functional image handling. I opened a Ticket over there #1350034: Please integrate with Module Manual Crop.

I think that these modules in combination would be likely the image handling solution for inline images I was looking for since Drupal 7 was released. And I think I'm not the only one looking for that. :)

As far as I understand this, Insert only works with the default Image widget provided by core fields. This is most certainly not something which can be dealt with on this end, but I hope if all of you who also would like to see those two modules work hand in hand let the devs of Insert know that this could be addressed soon.

Comments

matthijs’s picture

matthijs
Primary language Dutch
commented

Thanks for your great feedback! I think this is indeed an issue for the Insert module, but I'll try to keep track of this so that I can do my end if needed :-)

atlea’s picture

atlea commented

+1 for the praise of this module. Users love it. :)

Support for Insert probably has to be built into Manual Crop, as the maintainer of Insert has stated that they will only natively support the File and Image widgets, but extend support for other widgets through the use of hook_insert_widgets.

I'm not sure Insert would work together with cropping very intuitively, though, as the cropped image is not created before the node is saved...

This is how this hook looks for image field. The rest is added dynamically by javascript.

/**
 * Implementation of hook_insert_widgets().
 */
function image_insert_widgets() {
  return array(
    'image_image' => array(
      'element_type' => 'managed_file',
      'wrapper' => '.image-widget',
      'fields' => array(
        'alt' => 'input[name$="[alt]"], textarea[name$="[alt]"]',
        'title' => 'input[name$="[title]"], textarea[name$="[title]"]',
        'description' => 'input[name$="[description]"], textarea[name$="[description]"]',
      ),
    ),
  );
}
Anonymous’s picture

Anonymous (not verified) commented

The points you make are quite fundamental, I agree: Keeping it simple and intuitive and the fact that the cropped image is being created after the node was saved.

As for the intuitive part: the crop module could rely on the image style selection of the insert module, by making sure that only image styles can be selected which also are configured to offer manual crop functionality. Then I'd simply add a second button next to the "Insert" button: "Crop & Insert". So the user has two choices: either inserting an image with the selected image style as is - or cropping it before inserting.

Before inserting, the image would have to be generated server side, for that we'd need a workaround. Maybe this could be solved using an AJAX callback of some sorts. After all, the Insert module also inserts images which have been "freshly" uploaded, before a node was saved the first time.

But I see, this could get a lot more complicated than a layman's mind could imagine. :)

matthijs’s picture

matthijs
Primary language Dutch
commented
Assigned: Unassigned » matthijs
matthijs’s picture

matthijs
Primary language Dutch
commented

Hi,

Sorry for the insanely long wait on this, but I've just added some basic Insert support. Currently the crop area doesn't get saved before inserting the image, this is something I still have to work on.

I think saving the crop selection with ajax is a great idea, but won't it be confusing for the user if he/she re-crops the image? What I mean: you crop and insert -> the inserted image reflects your crop selection, but then you remove the image from the textarea, re-crop and reinsert -> the image will not change due to your browsers cache.

Any thoughts?

Anonymous’s picture

Anonymous (not verified) commented

Hi,

First of all I think Manual Crop is the best crop module out there and I tried 'em all!

I'm using it in combination with the Insert module and unless I'm doing something wrong, the max image width option of Insert seems to get completely ignored. Images get inserted at their original width.

Also, after uploading and cropping an image, the entity first has to be saved in order to insert the image cropped. When done without saving it'll be inserted without cropping.

Thanks for looking into it!

matthijs’s picture

matthijs
Primary language Dutch
commented

Hi,

Please read my comment above #1350044-5: Integration with Insert module concerning your "save the selection before insert" question.

I'm using the default hook to support Insert, so maybe there's a bug in the Insert module? I'll try to look in to this, but it might take a while :-)

matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Active » Postponed
matthijs’s picture

matthijs
Primary language Dutch
commented
Status: Postponed » Closed (works as designed)