Workflow Extensions port to D7

Glad you like this module miloyz!
I will consider it. Let's see how the port of the "mother" module, i.e. http://drupal.org/project/workflow matures and stabilises.
Also I'm pretty busy between now and Xmas, so I don't think it will be done until the New Year, unless someone wants to fund it.
Rik

what is the status of port?
can we help somehow?

Hi PlayfulWolf (love your name)!

I haven't done any work on this and I'm not aware that anyone else has. I'm on a big Drupal project with a tight deadline at the moment, so won't have time to do much work on this. But happy to answer any questions.

The D7 version of Workflow seems to be doing well now, http://drupal.org/project/usage/workflow , although could also do with some TLC, judging by the issue queue.

You can certainly help by offering patches, or in this case, it's probably more a rewrite. I can give you access to the repository if you are comfortable with Git. Consider contacting the current Workflow D7 maintainers, Bastlynn et al, and see what they say about moving this module into the Workflow package as a submodule.

Rik

hmm... so, there are no initial ports/rewrites? anyone?

the problem with me is that I am not comfortable with Git and I have no experience with workflow's code (for now)
but hapy to help with with testing

If you give me access to rep, I cannot promise, that I do much with it, at least for next 6-8weeks

Well, I'm in the same boat. Not much time for the next 3 months...

Someone else? This module has zero reported bugs against it and does not use any D6-specific features. Any good Drupal developer will have it done in less than 2 days...
The catch is that for some of its functionality it relies on Workflow Named Transitions, which also does not have a D7 port yet, although CodeElegance, http://drupal.org/user/154295, seems to be working on it...

Rik

codeelegance ported Workflow Named Transitions to D7.
See #1480970: Port to Drupal 7.
There's no packaged release yet, and it requires a few fixes, but it's working. :)

Initial run through Coder Upgrade, (first on coding standards, then on core api update.)
There's likely to be lots wrong here.

It's working so far with a few fixes.
See interdiff.txt for functional differences from last patch.

Here's a tarball of the D7 port.
Same thing as what the patch in #9 produces.

Thanks for all your work Jeff!
I'll create a branch in Git soon and check this in.
Rik

Note to self:
Darn, still haven't checked this in.....

Note to self:
Darn, still haven't checked this in.....

Thanks for this, Jeff! Here's another small bit that needed to be adapted for D7 (sorry, not somewhere where I can make a patch): in workflow_extensions_change_state_form($node), it refers to function workflow_get_workflow_for_type($type) that seems to not exist anymore in the D7 module. A fix could be something like:

$wobj = workflow_get_workflow_type_map_by_type($node->type);
  $wid = ($wobj != NULL) ? $wobj->wid : false;

  if (!$node || !($wid)) {
    return '';
  }

And then at the bottom of the file, there was a db_fetch_object that should be changed to use, e.g., $result->fetchObject()

With these changes, I was able to get the state transition form to work. Let me know if I can clarify any of that. Thanks again!

Lets get a branch :)

I've created a 7.x-1.x branch available as a dev snap shot: http://drupal.org/node/1774408 (or click the "View all releases" link at the bottom of the project page -- I don't understand why the system doesn't show the dev snap shot on the project page itself).

Includes JeffSchuler's D7 port and PeteS' patch.

NOT TESTED. This is just a long overdue baseline to move forward from.
Sorry for the delay. This module dropped off my radar for a while.

Thanks @RdeBoer!

(It just takes a bit for d.o.'s packaging system to actually publish the release to the project page.)

Thanks @RdeBoer!

(It just takes a bit for d.o.'s packaging system to actually publish the release to the project page.)

@jeffschuler
No thank you Jeff!

It was disrespectful to wait that long with applying your patch. Sorry again, I just forgot there was one.
The latest dev works without "Workflow Named Transitions". That module has still quite a few issues.

I have checked in some more fixes, in particular the two Views (/workflow-dashboard and /workflow-history) and the configuration page (links to it now appearing on the /admin/modules page and under Workflow on the config page admin/config).

What is still broken is the javascript to suppress the scheduling time UI until it is selected. Will look at that next.

Rik

Ok the javascript for the showing/hiding of the Scheduled transition Date+Time now works as well.

Tokens are still STUFFED. Sigh. If you don't use them, you should be ok with most of the functionality.

Rik

Should this issue be closed now?

@NancyDru
I guess we can. We can raise another issue for tokens,if anyone is using them.
Rik

Did you figure out tokens? I am using them... But I would not want to raise a new issue if they have been sorted.

Sorry. Just found that it is an on-going thing: https://drupal.org/node/1996256