Allow entry of only one dimension in Image Styles creation form.

I've found that altering function epsacrop_crop_image_form($data) after line 264 seems to do the trick ..

I added ..

  $form['width']['#required']=FALSE;
  $form['height']['#required']=FALSE;

.. after the part that loads the standard crop form data.

Not sure how many unintended consequences this might introduce yet though ..

Luke

I've also added some validation:

The code above becomes ..

  // Override default
  $form['width']['#required']=FALSE;
  $form['height']['#required']=FALSE;
  
  // Add validation callbacks to ensure that at least one value has been added
  $form['height']['#element_validate'] = array('_epsacrop_height_validate');
  $form['width']['#element_validate'] = array('_epsacrop_width_validate');
   

And the following functions are added ...

/**
 * Validate width information.
 * 
 * @access private
 * @param array $element
 * @param array &$form_state
 * @return void
 */
function _epsacrop_width_validate($element, &$form_state) {
  $value = $element['#value'];

  if (empty($value)) {
    if(empty($form_state['complete form']['data']['height']['#value'])) {
        form_error($element, t('Width cannot be empty without a height value'));
    }
  }
}


/**
 * Validate height information.
 * 
 * @access private
 * @param array $element
 * @param array &$form_state
 * @return void
 */
function _epsacrop_height_validate($element, &$form_state) {
  $value = $element['#value'];

  if (empty($value)) {
    if(empty($form_state['complete form']['data']['width']['#value'])) {
        form_error($element, t('Height cannot be empty without a width value'));
    }
  }
}

Here's a patch .. not certain that I've done this correctly - so any advice appreciated.

Hi Yvan

Thanks for the module - it's really useful :)

This works for me - but I'm a little bit worried that I might have disregarded something important.

Because only one value has been set - the initial view isn't very pleasing (before the crop has been defined) - but for my purposes it seems okay.

Maybe someone else could test and confirm?

Luke

Because there's potentially only one dimension stored for the image crop, when it comes to resizing the cropped image - we'll hit a problem as image_resize() requires two dimensions.

To deal with this eventuality, I'd propose changing image_resize() to image_scale on line 352 of epsacrop.module.

Luke

Any update on whether this could be included?

Hi - was this ever committed?

Thanks very much :)