This module really doesn't require the upload module to function unless you're using it's functions (which I did not check). For instance your module integrates perfectly with the filefield module for CCK. If you don't use Upload functions, I would drop that requirement and mention on the project page that this module supports CCK as well. Good work!

Comments

Chill35’s picture

Chill35 commented

Here's the reason why I use the upload module : I use its table {files} to find out which node the file is attached to, then I check if the user has permission to view that particular node, then from that, I can assume whether the file was successfully downloaded or not. Without that check, I get a lot of "false positives" : robots (and people too!) 'attempt' to download files to which they have no access.

Drupal is limited like that : when someone attempts to download an existing file with 'system/files' in the path, this 'invokes' ALL implementations of hook_file_download with the name of the file. And the only information I have, on my end, about the file, is its path. I don't know if another module blocked the file's download with a '-1' through its own implementation of hook_file_download, or allowed the file download by returning a header.

A coder's guide to file download in Drupal

wmostrey’s picture

wmostrey commented
Status: Active » Closed (fixed)