It's quite hard to figure out how this module works under the hood. Part of the problem is that the eid & pid columns are not very clear.

A simpler fix than renaming the columns would be to simply add a description for each of them in hook_schema(), which is generally best practice anyway.

CommentFileSizeAuthor
#1 1350542.simplenews_scheduler.hook_schema-description.patch2.86 KBjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1350542.simplenews_scheduler.hook_schema-description.patch2.86 KB
miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs review » Reviewed & tested by the community

Looks fine. Please commit.
This should be ported to 7.x also.

dgtlmoon’s picture

dgtlmoon commented
Status: Reviewed & tested by the community » Fixed

comitted to current 6.x dev, i think joachim will announce a 7.x soon

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Fixed » Patch (to be ported)

needs port then.

joachim’s picture

joachim commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Issue tags: +Novice

Marking this as a 7.x issue and tagging as novice.

NROTC_Webmaster’s picture

NROTC_Webmaster commented

This code is already in the 7 branch. I think it can be closed.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented

The new field frequency currently still lacks description... We should fix this also in order to complete the issues goal.

NROTC_Webmaster’s picture

NROTC_Webmaster commented
Category: bug » task
Status: Patch (to be ported) » Needs work

Changing the status

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Needs work » Fixed

Fixed. All have now a description.

Automatically closed -- issue fixed for 2 weeks with no activity.