Hi and thanks for your work on this module.

I tried to use the HTML5 player and got this error message when accessing the node page with a video field :

Notice : Trying to get property of non-object dans include() (ligne 15 dans /xxx/sites/all/modules/video/theme/video-play-html5.tpl.php)

Options : .mov file with radio "Video for everybody" checked.

The same node works OK if configured with the FLV player.

CommentFileSizeAuthor
#8 video-html5-thumbnail-1350680-8.patch1.52 KBdealancer
#6 Field settings 199.95 KBCountzero
#6 Field settings 2138.22 KBCountzero
#4 Fields40.65 KBCountzero
#4 Display21.96 KBCountzero
#2 Preset.jpg99.29 KBCountzero

Comments

hypertext200’s picture

hypertext200
he/him
Primary language Singhalese
Location New York City
commented
Status: Active » Postponed (maintainer needs more info)

What are the player configurations you have? What are the presets configurations you have?

Countzero’s picture

Countzero commented
Status: Postponed (maintainer needs more info) » Active
StatusFileSize
new Preset.jpg99.29 KB

In fact, I had no preset defined. Is it required ?

I don't want any conversion stuff (yet), so I thought it was not mandatory.

While creating one, I noticed the message comes from the config pages, not the node's.

On the node's page, a grey rectangle is displayed, and a click on it triggers the throbber, but nothing happens afterwards. It just spins forever.

I attached a screenshot of the preset's properties.

Maybe I'm just deeply misunderstanding the module's philosophy, and I'm sorry if it's the case.

hypertext200’s picture

hypertext200
he/him
Primary language Singhalese
Location New York City
commented
Status: Active » Postponed (maintainer needs more info)

If you do not want to convert videos then its easy to configure the video field. What are the video fields settings you have? Please provide a screenshot.

Countzero’s picture

Countzero commented
StatusFileSize
new Display21.96 KB
new Fields40.65 KB

I'm not too sure what page settings you want.

Here are the 'Manage Fields' tab and the 'Manage Display' tab

hypertext200’s picture

hypertext200
he/him
Primary language Singhalese
Location New York City
commented

I need video field settings

Countzero’s picture

Countzero commented
StatusFileSize
new Field settings 2138.22 KB
new Field settings 199.95 KB

Here thay are.

Saoirse1916’s picture

Saoirse1916 commented

In the file /sites/all/modules/video/theme/video-play-html5.tpl.php, change line 15 from this:

<video width="<?php echo $video->player_width; ?>" autobuffer="<?php print $video->autobuffering; ?>" height="<?php echo $video->player_height; ?>" controls="controls" preload="<?php print $video->autobuffering ? 'auto' : 'metadata'; ?>" poster="<?php echo $video->thumbnail->url; ?>">

to this:

<video width="<?php echo $video->player_width; ?>" autobuffer="<?php print $video->autobuffering; ?>" height="<?php echo $video->player_height; ?>" controls="controls" preload="<?php print $video->autobuffering ? 'auto' : 'metadata'; ?>">

The problem is the call for poster="<?php echo $video->thumbnail->url; ?> -- at least in my case, $video->thumbnail is null and so $video->thumbnail->url does not exist, hence this error.

dealancer’s picture

dealancer commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new video-html5-thumbnail-1350680-8.patch1.52 KB

@Saoirse1916, right, this is cause of $video->thumbnail object is null.

Here is a patch.

Jorrit’s picture

Jorrit commented
Status: Needs review » Fixed

Committed to branch 7.x-2.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.