Add utility function to retrieve list of users with workbench access

Nice. Notes:

* I would always pass an array to $rids and make its default array(). Mixing types like that leads to bugs. If you need to pass a single rid, use a wrapper function in the style of _load() calling _load_multiple() in D7.

* If possible, this should be abstracted for use with workbench_access_editor_form() and workbench_access_role_form(), which duplicate some of this logic.

Refactoring both form functions would be ideal.

You can create a new issue in the Webmaster queue to take over a project.

See http://drupal.org/node/251466

Nice. I'll try to take a look and clean it up some. For instance, since we have two functions that are siblings:

* workbench_access_user_role_assignments()
* workbench_access_users()

I would go for consistency and rename them as:

* workbench_access_get_section_users()
* workbench_access_get_section_roles()

Changing to 'sections' from 'assignments' for internal consistency.

Awesome.

Here's a re-roll that fixes the following errors:

• Missing function workbench_access_users() causes fatal error.
• Turns $roles argument to array() from NULL to avoid type mixing.
• Turns $pager into an integer, to allow for variable pager lengths. Defaults to 0.
• Removes the $page argument on the editor form call, because I don't know if that actually works. The form theme function isn't prepared to handler a pager AFAIK.
• Docblock formatting consistency (see d.o. documentation).
• Properly documents return functions.

I think the pager needs testing, and the whole change likely needs some form of test.

nice to see that feature grow. :-D
i would give it a try. is the list available as token?

No. That would be a follow-up patch.

I can see a pager being useful if you have > 50 entries. We just have to support it in the theme code.

We need this to be sensitive to the fact that role id 2 DRUPAL_AUTHENTICATED_RID is not stored in the dang database.

What if we add the ability to extract the users assigned to that editorial section AND ITS PARENTS ? Does it make sense in the initial requirement of this issue ? I'm working on a patch for that...

the patch.

Let's set to "needs review" for automated testing.

my second patch (the first one was built on the top of the 7.x-1.0 version. This one is for dev version.) My local tests are ok but because I had to integrate some others modification made in between (especially Adding authenticated user role fails to list users) i'm not sure it's perfect.

And: Let's set to "needs review" for automated testing.

PHP Fatal error: Call to undefined function workbench_access_users() in /workbench_access/workbench_access.admin.inc on line 496

Then why did it pass the testbot?

@Sborsody - What were you doing when that happened?

@Sborsody
Yes there was a motherless call to workbench_access_users() into my previous patch.
I did a little bit of clean-up inside this new patch and i repack it against latest state of dev branch.

• function workbench_access_get_section_users_by_account
  • renamed (previously named workbench_access_user_editor_assignments): following agentrickard recommendation (#6) and terminology already in use in the module.
  • optional argument roles: I kept it however it is not use (internally at least), My view is it is too specific. keen to remove it.
  • remove unused sql join with table role_permission in the query
  • update function description
  • pager: i kept it however i don't undestand if it is appropriated here...
• function workbench_access_get_section_users_by_role
  • renamed (previously named workbench_access_user_role_assignments): following agentrickard recommendation (#6) and terminology already in use in the module.
  • update function description
  • optional argument roles: I kept it however it is not use (internally at least), My view is it is too specific. keen to remove it.
  • use db_select instead of db_query
• I split apart the function workbench_access_get_section_users_by_role
  to expose another function: workbench_access_get_section_roles: Return an array of roles who are editors for a section

+++ b/workbench_access.module
@@ -2151,3 +2151,145 @@ function workbench_access_update_records($find, $replace, $scheme = NULL) {
+function workbench_access_get_section_users_by_account($access_type, $access_type_id, $roles = array(), $pager = 0) {

$page = FALSE maybe? = 0 seems a bit odd

+++ b/workbench_access.module
@@ -2151,3 +2151,145 @@ function workbench_access_update_records($find, $replace, $scheme = NULL) {
+function workbench_access_get_section_roles($access_type, $access_type_id, $roles = array(), $depth=FALSE) {

$depth = FALSE

+++ b/workbench_access.module
@@ -2151,3 +2151,145 @@ function workbench_access_update_records($find, $replace, $scheme = NULL) {
+  if (!$roles || empty($roles)) {

wat?

+++ b/workbench_access.module
@@ -2151,3 +2151,145 @@ function workbench_access_update_records($find, $replace, $scheme = NULL) {
+  } else {

}
else {

Would it be better to have a function that get users one calls to get uid's that are in the user table, not restricted by role, e.g. if looking to see what user assignment exists that no longer have access, etc.