In _simplenews_scheduler_new_edition():

  $node = node_build_content($node, FALSE, FALSE);
  $content = drupal_render($node->content);

The $content variable holds the full rendered content of the node -- but it's never used subsequently!

CommentFileSizeAuthor
#1 1350794.simplenews_scheduler.switch-anon-user-render.patch1003 bytesjoachim

Comments

joachim’s picture

joachim commented
Status: Active » Needs review
StatusFileSize
new 1350794.simplenews_scheduler.switch-anon-user-render.patch1003 bytes

Here's a patch for switching user.

joachim’s picture

joachim commented
Status: Needs review » Active

Ignore last patch -- I uploaded to the wrong issue sorry.

dgtlmoon’s picture

dgtlmoon commented

There was a reason for this with earlier simplenews module where it was required to make something inside of simplenews trigger, but now it may be defunkt

dgtlmoon’s picture

dgtlmoon commented
Priority: Critical » Normal

probably not critical

joachim’s picture

joachim commented
Version: 6.x-2.x-dev » 7.x-1.x-dev
Category: bug » feature

Actually using $content as the body for the new edition node would mean that fields work. One very useful consequence would be that Views can be pulled in with http://drupal.org/project/viewfield rather than the rather less graceful http://drupal.org/project/insert_view (also, more stable module, and safer for content editors to edit the parent newsletter node).

Adding this as an option to parent newsletter nodes would be a useful feature I think.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

We're cloning the whole node object in D7 in simplenews_scheduler_clone_node(), so that should take care of the fields without the need to render them. While that function could probably be improved (there is a commented out line about the title there), it shouldn't be necessary, I don't think this code exists in 7.x-1.x.

joachim’s picture

joachim commented

> We're cloning the whole node object in D7 in simplenews_scheduler_clone_node(), so that should take care of the fields without the need to render them.

That's not going to have the desired effect though.

Things like Views need to be crystallized at the time of sending so that when the sent edition node is looked at on the site months later it looks like what was sent.

Eg, if your newsletter embeds '5 latest blog posts', the edition node should show the 5 latest at the time of sending, and when you look at the node 6 months later it should show the same ones.

That means we may need to add some sort of setting or system to skip some fields from the cloning perhaps?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

What we could do is add a special view mode for this, then the node is rendered in that one and the result is written in the body field or something like that. But the body is a field as well... So maybe a configuration that allows to configure into which field the node should be rendered into. If that is set, then we render, otherwise we clone the node object.

We shouldn't render it by default, in our case, the content is different depending on the subscriber, what we're doing is re-generating it based on the newsletter creation date (which is possible in our case, might not be for others).

matt b’s picture

matt b
Primary language English
commented
Issue summary: View changes

Does #5 explain https://www.drupal.org/node/2442521 ?