There are some problems with the existing javascript for the bbq/history integration and I need to rewrite it. I'm hoping this rewrite will also make it easy to provide this support for the classic quicktabs renderer...

CommentFileSizeAuthor
#1 1350832.refactor-bbq-js.patch11.74 KBkatbailey

Comments

katbailey’s picture

katbailey commented
Status: Active » Needs review
StatusFileSize
new 1350832.refactor-bbq-js.patch11.74 KB

Would love to get people to test this out before I commit it as I stripped out a lot from the js that was there and I'm not sure if I've maybe missed some use cases...

tnightingale’s picture

tnightingale commented

Just tested the patch, confirming it applies cleanly and doesn't break the accordion functionality we use (collapse all option).

ckng’s picture

ckng
Primary language English
commented

This seems to be already committed?
http://drupalcode.org/project/quicktabs.git/commit/f200208

Is it possible to keep track of which link that are being clicked?
Or which section of the accordion link being click, i.e. ABC accordion tab, link within B is clicked, B will remain open after new page loaded?

If not, is there something similar?

bennos’s picture

bennos commented

Hm, looks like the commits
http://drupalcode.org/project/quicktabs.git/commit/68f7603
http://drupalcode.org/project/quicktabs.git/commit/8930f85
http://drupalcode.org/project/quicktabs.git/commit/d10228d

are not right committed to the 7.3.x DEV version.

@katbailey
Have a look at it.

katbailey’s picture

katbailey commented

@bennos, the commit for *this* issue is the one linked to by @ckng in #3 (although that's just the merge commit - here's the main commit http://drupalcode.org/project/quicktabs.git/commitdiff/cf704ca346a2a9004...).

The commits you link to above are for #1877560: Overhaul the options mechanism to make it more sane and I haven't committed this to the main branch yet because I was hoping to get people to test it out as it's a pretty big change. There's a patch in that issue - it would be awesome if you could apply it and test it out and leave your feedback in the issue.

katbailey’s picture

katbailey commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.