The module is not using the library api! There are a few reasons why this is bad!

Ill write and post a patch soon :)

greetings

CommentFileSizeAuthor
#9 sass-use_library_api-1351686-9.patch1.92 KBklonos
#6 sass-use_library_api-1351686.patch2.22 KBmrded
#5 sass.module.rej_.txt1.11 KBcapellic
#4 0001-Use-Library-API.patch1.93 KBmrded

Comments

eigentor’s picture

eigentor commented
Title: User Library API » Use Library API

One more person noticing this.
Modules installing libraries inside the module directory are soo D6 ;)
Should not be too hard to implement usage of the libraries module and put the library into /sites/all/library

ambient.impact’s picture

ambient.impact
they/them
Primary language English
Location Toronto
commented

I agree, the Libraries API would be the right way to go. This has my vote.

chrisjlee’s picture

chrisjlee commented

Just use the drupal sassy module with phpsass (fork of phamlp). phpsass is a little better maintained.

It has this already in place and some vast improvements.

mrded’s picture

mrded commented
Status: Active » Needs review
StatusFileSize
new 0001-Use-Library-API.patch1.93 KB

Please check my patch

capellic’s picture

capellic
he/him/his
Location Austin, Texas
commented
Status: Needs review » Needs work
StatusFileSize
new sass.module.rej1.11 KB

Thanks for the patch, though it didn't apply cleanly.

Got this error when trying to apply with git:

% git apply 0001-Use-Library-API.patch.txt
sites/all/modules/contrib/sass/0001-Use-Library-API.patch.txt:38: trailing whitespace.

warning: 1 line adds whitespace errors.

Got this error when trying to apply with patch. sass.module.rej file attached.

% patch -p1 < 0001-Use-Library-API.patch.txt
patching file README.txt
patching file sass.module
Hunk #1 FAILED at 74.
1 out of 1 hunk FAILED -- saving rejects to file sass.module.rej

I ended up apply the code manually.

mrded’s picture

mrded commented
Status: Needs work » Needs review
StatusFileSize
new sass-use_library_api-1351686.patch2.22 KB

oh, sorry my text editor. This is new patch

elvis2’s picture

elvis2 commented

#6 patch failed while patching, for SASS version 7.x-2.0.

patching file README.txt
patching file sass.module
Hunk #1 FAILED at 71.
1 out of 1 hunk FAILED -- saving rejects to file sass.module.rej

mrded’s picture

mrded commented

C'mon, it's just few lines. Apply it manually :)

klonos’s picture

klonos
he/him
Primary language English
Location 90% Melbourne, Australia - 10% Larissa, Greece
commented
Issue summary: View changes
StatusFileSize
new sass-use_library_api-1351686-9.patch1.92 KB

...ok here's an updated patch against 7.x-2.0 for the lazy ...both those too lazy to apply manually and those too lazy to re-roll and upload a new patch :P

With love from a person too lazy to actually review the patch.

PS: all credits to Dmitry - I just rerolled.