Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Add the option to make the search options not visible
I will probably do this as a permission per role.
(see http://drupal.org/node/134905 for rationale)
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | site_user_list_patch_1.txt | 9.15 KB | scafmac |
| #1 | site_user_list_patch_0.txt | 9.15 KB | scafmac |
Comments
Comment #1
scafmac commentedHi Ricky,
I don't think this or the display options toggle make sense as a permission. Permissions in my mind are used for restricting access to potentially powerful functionality. Items that some users need access to, but would be too dangerous in the hands of the public; the devel module is a great example.
On the other hand admin/setting options are for configuring the functionality of modules. Which is what I want. It isn't that I believe the search or display options need to be restricted from certain users, I just want to configure the module so they never display. Along the same lines, I'd like to configure the module so that the Site User List page and menu item had different titles.
Add to that the fact that the admin/user/access, especially when a large number of roles exist and there is a large number of modules, has an unwieldy UI, I don't see the rational for making this a permission. Clearly both are an option if you believe that some configurations will want to restrict the options to certain roles.
Attached is a patch that includes:
Don't mean to be clumping these up on you. It is just what I was working on yesterday before I saw your post to go the permission route. The title just seemed like a no-brainer to extend the flexibility of the module once I was adding options to the admin/settings page.
Take it for a test drive and see if you like the admin/settings model of configuring the module. If you're uninterested in these changes, let me know and I'll stop bothering you with them.
Cheers,
Matt
Comment #2
scafmac commentedHi Ricky,
I don't think this or the display options toggle make sense as a permission. Permissions in my mind are used for restricting access to potentially powerful functionality. Items that some users need access to, but would be too dangerous in the hands of the public; the devel module is a great example.
On the other hand admin/setting options are for configuring the functionality of modules. Which is what I want. It isn't that I believe the search or display options need to be restricted from certain users, I just want to configure the module so they never display. Along the same lines, I'd like to configure the module so that the Site User List page and menu item had different titles.
Add to that the fact that the admin/user/access, especially when a large number of roles exist and there is a large number of modules, has an unwieldy UI, I don't see the rational for making this a permission. Clearly both are an option if you believe that some configurations will want to restrict the options to certain roles.
Attached is a patch that includes:
Don't mean to be clumping these up on you. It is just what I was working on yesterday before I saw your post to go the permission route. The title just seemed like a no-brainer to extend the flexibility of the module once I was adding options to the admin/settings page.
Take it for a test drive and see if you like the admin/settings model of configuring the module. If you're uninterested in these changes, let me know and I'll stop bothering you with them.
Cheers,
Matt
Comment #3
scafmac commentedOoops - sorry about the double post.
Comment #4
pukku commentedHi! I see your point about configuring vs. access. I've already applied the title change. I'm thinking that I can address several of your critiques by allowing you to configure both the display and the weight of the various items. I will see what I come up with.
I'm not going to apply your patch monolithically (in part because I'd already applied the part for $_REQUEST issues, so the patch isn't really valid anymore).
Thanks!
Ricky
Comment #5
scafmac commentedApply the patch anyway you want. I knew it wasn't ideal when I posted it, I just wanted you to have something to test drive if you wanted. I'll synch with CVS so any additional patches (found a bug) will not be monolithic.
Comment #6
pukku commentedJust committed a new version that I think will address this issue...
Comment #7
pukku commented