save trackback output to $node->content[] instead of altering $node->body

Hi Fabio,

IMO, 'view' is the operation to show the node content. However trackback isn't a content of node, but it relates to node like comment. Therefore the trackback module uses 'alter' for printing it.

I wasn't able to use the $node->content[] from the alter operation but only on the view.
I think that the view operation should be used every time a module display informations on the node.

Using $node->content[] is good because helps a lot in theming.

@zorac: This is a serious shortcoming of the module. In 4.7 I had to hack around this to achieve very basic theming.

I re-rolled the patch based on the latest in CVS, improving it to make each distinct element themeable. Default behavior is unaffected and has been tested. This is ready to commit.

This patch should append received trackbacks to node body in RSS feeds. And received trackbacks URL will be deteted by the auto-detection.

Why should they be appended to RSS feed? Comments are not, so I do not think this is the right behavior. As for the note on auto-detection, I am not sure I understand what the problem is.

Even if these points are valid, perhaps the best approach is the create an admin setting to choose the mode of trackback output.

What problem does this patch solve?
I don't understand your problem. If you tell me it, I wish to think.

The problem is that right now trackbacks are impossible to theme and they can look very ugly, depending on how the rest of the theme is organized. Moving the module output out of body / teaser fields gives control over output to themer, where it belongs.

Of course if you are not doing heavy theming this may not be a problem for you.

theme_trackback, theme_trackbacks and theme_trackback_url functions can be overridden for theming.

You want to move the trackback list, don't you?

@dkruglyak: Now the output of trackback module is saved into $node->trackback array. Does this change solve your problem?

As I look at your latest code (Revision 1.64.2.15), this is getting close but not really there. The problem is explicit modification of $node->body, which is still present in your code:

This really negates any gains for theming, since the module outputs trackback markup before theme can move it around. The whole point of adding $node->content in 5.0 API was to serve as a repository of these fragments written before / after nodes. See details in 5.0 module upgrade guide: http://drupal.org/node/64279#node-view

In 4.7 I did a hack by creating a similar $node->trackback array and used the theme (not trackback.module) to output it. However the advantage of $node->content in 5.0 is that is it handled very well by default - even if theme does nothing.

I'll just throw in my two cents that I would like to be able to move trackbacks around. I think it would be great to have a trackbacks block for a node, but the feature request here is a good start.

Re-rolled my patch against the latest. Real control over theming requires changing to 'view' hook and using proper content[] approach.

Tested and works just fine. Please commit!

zorac - Can you please review the "view" action in the hook_nodeapi() documentation? That describes the proper way to change node output. It should be done through $node->content[], not by modifying $node->body.
http://api.drupal.org/api/function/hook_nodeapi/5

Attached is a respin of the patch that fixes this problem, applied against 5.x-1.4

chip: Thanks for updating the patch!

zorac: This is commit-worthy and bug-free. Please get the patch into CVS!

@chip: you should probably use the -u option to the diff command to generate a little bit more readable diff output (see drupal handbook for detailed info)

This patch has a problem to send trackbacks to the sender page of recieved trackbacks by auto-detection.

@zorac - could you explain what the problem is and how *exactly* to reproduce it? have you tried the patch?

To those looking for a more readable patch file, I am attaching it now.

+1

@zorac: The patch does not seem to change functionality of TrackBack module; it's just moving the module output into a proper location. Your past follow-ups are very incomprehensible. Operation 'view' is definitely the right way to go, but you seem to have issues with that. Please elaborate.

Just commit it already!

There are no problems here. Please read up on hook documentation if you do not understand how $node->content[] works.

Please look at line 677 of trackback.module.

That's a no-brainer. Just use node_view in trackback_urls_via_nodebody function. Look at that function's documentation to see how it invokes everything necessary, including hooks and theming: http://api.drupal.org/api/function/node_view/5

Updated patch attached.

@dkruglyak: I seem that you don't understand the behavior of trackback_urls_via_nodebody function.
By this patch, it sends unexpected trackback pings when trackback_urls_via_nodebody function works with a node that has received trackbacks.

OK, now I think I understand what you are trying to do with trackback sending.

We need to build content[] array without any of that trackback stuff you originally appended with your 'alter' hook. I made a very simple change that removes trackback-specific parts of content[] array before parsing for URLs.

I verified that now parsable text is identical to the one before the move to 'view' hook.

Now this should be ready to commit.

Okay, I'm floored ;-)
I understand your idea and I will work for this task to fix other little problems.

Why floored? Do you see any other problems with this solution?

I verified that the text generated for URL detection is the same as in your original code. This is ready to go - just give it a try.

Automatically closed -- issue fixed for two weeks with no activity.