Closed (fixed)
Project:
Freelinking
Version:
7.x-3.x-dev
Component:
Code
Priority:
Major
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
24 Nov 2011 at 18:45 UTC
Updated:
20 Jul 2012 at 15:11 UTC
Jump to comment: Most recent file
Comments
Comment #1
misc commentedAnd here is the patch. I also needed to change in one of the plugins for freelinking.
Comment #2
misc commentedForgott to change status (sorry, some day I will learn).
Comment #3
misc commentedCleaned up the patch a little bit.
Comment #4
gbenciolini commentedExcuse me my ignorance and my bad english.
How could i installa patch without a consolle? I have my blog on a hosting server.
Thanks!
Comment #5
misc commentedThere is no ignorance in a question :-)
If you look in the patch you could see where and what to change in you original file - so you could do that in an editor. A little bit tricky to get everything right, but it works. Also there are tools that could help you with that also.
Comment #6
gbenciolini commentedThanks a lot !!!!!
Comment #7
Akra commentedThanks for the patch fix most of my problem, but only have this error,
Notice: Undefined index: title en freelinking_prepopulate_node_settings() (línea 109 in freelinking_prepopulate\freelinking_prepopulate.module), well thx for ur time, and sry for my bad english
Comment #8
misc commentedI will look into that and do a new patch.
Comment #9
jzornig commentedI rerolled the #3 patch for the feb 21 dev
Comment #10
misc commentedComment #11
Flandry commentedI applied the patch manually (nb i did not apply the multiline comment to hide the "unknown" chunk of code as the patch does) and it took care of the error messages i was getting when configuring Freelinking and when previewing a page that invoked freelinking. Something strange happened at first (illegal option) with the Advanced Settings checkbox under Createnode Plugin Settings, but after unchecking and then rechecking that option (Use the Linking Node for Create Node presets), it seems to be doing that.
I really like freelinking but the utility (for me, at least) was limited without the Prepopulate addition, and that is broken in the present release. Please apply the patch and tag a new release so others less inclined to apply patches can enjoy your great work!
Comment #12
misc commentedGood point, we should prepare for a new release.
Comment #13
rishi_cs357 commentedHey MiSc ...
I have applied #9 patch most of errors have been resolved now ...i am getting following errors....
Thanx in advance.Now what to do?
Notice: Undefined variable: object in freelinking_prepopulate_fields_from_page() (line 43 of ....../sites/all/modules/wiki/freelinking/modules/freelinking_prepopulate/freelinking_prepopulate.utilities.inc).
Notice: Trying to get property of non-object in freelinking_prepopulate_fields_from_page() (line 43 of ...../sites/all/modules/wiki/freelinking/modules/freelinking_prepopulate/freelinking_prepopulate.utilities.inc).
-----Rishi
Comment #14
darrenmothersele commentedRerolled the patch from #9 adding back in the object loading.
Comment #15
winklet commentedI'm not able to apply any of these patches! I am working from 7.x-3.x-dev. Is this the wrong version? I'm a newbie to applying patches and maybe need some help. I've been able to do it before but this time it simply will not do it.
Comment #16
misc commentedHow do you apply the patch?
Comment #17
winklet commentedI put the patch file in the freelinking module folder and then use Tortoise SVN to apply the patch.
Comment #18
misc commentedI see that the patch in #14 does not work, I will check it.
Comment #19
misc commentedUpdated patch, it should now work. I apply patches with git (if I have downloaded the module via git): git apply -v patchname or with patch like patch -p1 < patchname. Both done in the module folder. (If you have curl and git you could do curl -0 patchurl | git apply -)
Comment #20
winklet commentedThanks. I think I was able to apply this patch, however it has not solved any of the problems (multiple error notices) when trying to add freelinks in the page bodies. I think I am going to give up and find something other than Drupal for the wiki we want to set up.
Comment #21
misc commented@winklet, I attached a patched version of the module. Test this if you like.
Comment #22
misc commentedPatch need review by the way :-)
Comment #23
misc commentedAlso @winklet, if you have problems, better give us the errors that you get, and we could together solve it. Just "has not solved any of the problems" helps nobody.
Comment #24
juampynr commentedThe issues reported here are very similar as the ones fixed at #1671418: Several E_NOTICE fixes at freelinking_prepopulate. I personally have reviewed little of Freelinking Prepopulate and it seemed that it had (and may still have) several bugs. In order to stabilise it I have created another issue to implement tests for it: #1673694: Add tests to Prepopulate submodule.
I have manually applied patch from comment #21. Many thanks to everyone!
http://drupalcode.org/project/freelinking.git/commitdiff/d1e9561