When upgrading from Commons 2.3 to the latest development snapshot (which includes dev versions of Activity log, FBSS, FBSMP & Digests), tokens in Activity log messages seem to not be evaluated.

I suggest that Activity log clear the message caches and regenerate activity for 14 days through a hook_update_N() implementation.

I haven't tested this on a vanilla Drupal core install with the latest releases of Activity log upgrading to the dev releases, but I suspect this is present there as well and this is a result of the many commits since the last release.

CommentFileSizeAuthor
#4 activity-log-upgrade-1352140.patch1.88 KBicecreamyou
#1 activity-log-templates.png77.17 KBezra-g

Comments

ezra-g’s picture

ezra-g commented
StatusFileSize
new activity-log-templates.png77.17 KB

Here's a screenshot after an upgrade of a fresh install of 2.3: Activity log templates unevaluated

icecreamyou’s picture

icecreamyou commented

Well, it does say on the project page,

An explicit upgrade path between 2.x releases will not be provided until 2.0-RC1, although you will be able to use the "regenerate" functionality for this purpose.

So, I'm not too concerned about this. And custom Activity Log rules will experience the problem you describe no matter what after this upgrade, until someone goes and saves each template again. But I'll accept a patch. :-)

icecreamyou’s picture

icecreamyou commented

I guess if I accept the idea that this issue needs to happen, that makes it a blocker for a new release. Possibly the only blocker. So it looks like this will need to get done.

icecreamyou’s picture

icecreamyou commented
Status: Active » Needs review
StatusFileSize
new activity-log-upgrade-1352140.patch1.88 KB
icecreamyou’s picture

icecreamyou commented

BTW if someone reviews this and confirms it works (notwithstanding problems with regenerating activity...) I'll commit it and tag another beta release.

icecreamyou’s picture

icecreamyou commented
Status: Needs review » Fixed

Committed.

Since no one else reviewed this, I'm gonna let it sit for a bit before tagging a new release.

ezra-g’s picture

ezra-g commented
Status: Fixed » Needs work

This regeneration resulted in all unreplaced tokens "[author:picture] [author:user] added the [node:type-name] [node:title] in [node:ogname] [node:small]" activity log items. Ultimately the solution for the site I was upgrading was to delete a custom rule, then clear the template caches, then regenerate activity.

With the variation between sites on steps necessary to upgrade and the potential for activity regeneration to take a long time on highly active sites, I think I was mistaken in suggesting we add this :\.

I can file a patch to remote this update.

icecreamyou’s picture

icecreamyou commented
Status: Needs work » Closed (won't fix)

Ultimately the solution for the site I was upgrading was to delete a custom rule, then clear the template caches, then regenerate activity.

As I noted in #2, "custom[ized] Activity Log rules will experience the problem you describe no matter what after this upgrade, until someone goes and saves each template again." I don't see any way of getting around that, patch or no patch.

That said, a lot of people will probably have customizations, and for them running the upgrade will just be wasted time.

No need to file a patch -- I removed the upgrade function.

atin81’s picture

atin81 commented

Ice, do you mean that if this issue presents on a website the only way for solve it's re-save every rule generated text that we want to display on Activiy Logs?

icecreamyou’s picture

icecreamyou commented

You don't have to re-save default rules that you haven't changed. But yes, if you created the rules yourself or if you modified the default ones, you need to re-save them.

atin81’s picture

atin81 commented

In my test website all rules display unevaluated tokens. Guess if uninstall will be easier!