Problem/Motivation

The List-handler of EntityFieldHandlerHelper doesn't provide a posibility to generate a html-list.
Would be nice to have such an option - especially to build views.

Proposed resolution

Add such a handler. Please see the attached patch for a possible solution.

Remaining tasks

Review patch.

User interface changes

New option "Output values as list" in "List-handling".
New setting "List type" if "Output values as list" is selected.

API changes

none.

CommentFileSizeAuthor
#3 entity-EntityFieldHandlerHelper-add-html-list-output.patch-1352454-3.patch4.8 KBdas-peter
entity-EntityFieldHandlerHelper-add-html-list-output.patch4.18 KBdas-peter

Comments

das-peter’s picture

das-peter commented
Issue tags: +dvcs11

Added Views sprint tag.

fubhy’s picture

fubhy commented
Status: Needs review » Needs work 
+++ b/views/handlers/entity_views_field_handler_helper.incundefined
@@ -420,20 +433,32 @@ class EntityFieldHandlerHelper {
+          return theme('item_list', array(
+            'items' =>  $inner_values,

There are 2 whitespace characters in the 'items' line (behind the arrow).

Other than that it looks okay. Just need to see what fago thinks about it. :)

das-peter’s picture

das-peter commented
Status: Needs work » Needs review
StatusFileSize
new entity-EntityFieldHandlerHelper-add-html-list-output.patch-1352454-3.patch4.8 KB

Here we go, re-rolled and fixed also other coding standard violations in the existing code.

Status: Needs review » Needs work
Issue tags: -dvcs11

The last submitted patch, entity-EntityFieldHandlerHelper-add-html-list-output.patch-1352454-3.patch, failed testing.

das-peter’s picture

das-peter commented
Status: Needs work » Needs review
Issue tags: +dvcs11

#3: entity-EntityFieldHandlerHelper-add-html-list-output.patch-1352454-3.patch queued for re-testing.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

Sry for the late review.

+++ b/views/handlers/entity_views_field_handler_helper.inc
@@ -6,7 +6,8 @@
- * Helper class containing static implementations of common field handler methods.
+ * Helper class containing static implementations of common field handler
+ * methods.

The first line actually may be longer than 80 chars, but should not break. So let's keep it as it was.

Except for that, patch looked good. Committed it, thanks.

Automatically closed -- issue fixed for 2 weeks with no activity.