[D7] yurist

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• ./template.php: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function get_main_menu_tree() {
  

• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./template.php ./yurist.info ./block.tpl.php ./page.tpl.php
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

FILE: ...7-pareview/sites/all/modules/pareview_temp/test_candidate/block.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
11 | ERROR | Concat operator must be surrounded by spaces
11 | ERROR | Concat operator must be surrounded by spaces
--------------------------------------------------------------------------------

FILE: ...pareview/sites/all/modules/pareview_temp/test_candidate/comment.tpl.php
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
6 | ERROR | Whitespace found at end of line
16 | ERROR | Whitespace found at end of line
--------------------------------------------------------------------------------

FILE: ...rupal-7-pareview/sites/all/modules/pareview_temp/test_candidate/menu.js
--------------------------------------------------------------------------------
FOUND 2 ERROR(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
9 | ERROR | Spaces must be used to indent lines; tabs are not allowed
10 | ERROR | Spaces must be used to indent lines; tabs are not allowed
--------------------------------------------------------------------------------

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/node.tpl.php
--------------------------------------------------------------------------------
FOUND 0 ERROR(S) AND 1 WARNING(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
23 | WARNING | Line exceeds 80 characters; contains 83 characters
--------------------------------------------------------------------------------

FILE: ...-7-pareview/sites/all/modules/pareview_temp/test_candidate/template.php
--------------------------------------------------------------------------------
FOUND 7 ERROR(S) AFFECTING 7 LINE(S)
--------------------------------------------------------------------------------
3 | ERROR | The second line in the file doc comment must be " * @file"
8 | ERROR | Missing function doc comment
19 | ERROR | More than 2 empty lines are not allowed
20 | ERROR | More than 2 empty lines are not allowed
21 | ERROR | More than 2 empty lines are not allowed
22 | ERROR | More than 2 empty lines are not allowed
46 | ERROR | Space before closing parenthesis of function call prohibited
--------------------------------------------------------------------------------

Hi internet-marketing.by

I ran your code through the automated review
http://ventral.org/pareview/httpgitdrupalorgsandboxinternet-marketingby1...

The first error can probably be fixed by removing lines 8-10 of your template.php - the closing ?> and opening <?php seems to trigger that message.
http://drupal.org/node/318#phptags

There are also a lot of flags in your style.css file
-You should be using 2 spaces instead of 4 spaces for your intenting
-You should use lowercase letters on your color codes

Check out the Properties section here: http://drupal.org/node/302199

I ran the review again and found some more issues:
http://ventral.org/pareview/httpgitdrupalorgsandboxinternet-marketingby1...

Line 23 of page.tpl.php - need to remove the space before the closing )

Also in the style.css, multiple selectors should each be on a single line. The first instance of this is line 21, but there are multiple places where this is occurring. You should see a full list at the link above.

I installed this theme on a test site I'm using to develop my own theme. There are a few issues I found right away.

The first is that the order of regions on the Blocks administration page (which is taken from the order in the .info file), doesn't match the order of the regions from top to bottom on the page. So, for example, "Content bottom" appears above "Content." This makes it more difficult to assign blocks to the correct region. There are also two regions defined in the .info file that aren't rendered in the page template ("Page Bottom" and "Left Bottom").

Secondly, I think you should remove the photo of the man and the Cyrillic writing. That is going to be off-putting for a lot of sites, particularly those in languages that use other alphabets :) If you take that out completely you could give people the flexibility to put something else in that region, like a mission statement or search box. Remove the book and gavel image in the bottom-right too.

You might want to look into advertising regulations for themes and modules and see if you're allowed to put your credit in the footer. I would assume not, but I might be wrong ...

Otherwise it looks pretty good. As an added improvement for the future, you could consider adding colour module support so users can change the red colour to whatever they want (tip: use the Bartik preview method, not the Garland sliced images one!)

There is still some coding standard issues:

Please check http://ventral.org/pareview/httpgitdrupalorgsandboxinternet-marketingby1....
After any changes, try to use this tool for check for coding issues.

Clean your README.txt file in master branch, see http://drupal.org/node/1127732.

EDIT: Duplicated reply.

Automated review looks perfect.
I think you should remove the readme.txt from your master branch.

There's some collapsed part.
I use firefox 11, and the top and main content is not in one line.
See the screenshots.

@betawerk - a README should be in the master branch, pointing to the correct branch/branches.
This is RTBC for me.

We are currently quite busy with all the project applications and I can only review projects with a review bonus. Please help me reviewing and I'll take a look at your project right away :-)

Sorry for the delay.

There is still a master branch, make sure to set the correct default branch: http://drupal.org/node/1659588 . Then remove the master branch, see also step 6 and 7 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. You have to get a review bonus to get a review from me.

manual review:

1. yurist_links(): does not do anything different than theme_links(), why do you need it?
2. Please note: All user accounts are for individuals. Accounts created for more than one user will be blocked when discovered.

But that are just minor issues, so ...

Thanks for your contribution, internet-marketing.by!

I updated your account to let you promote this to a full project and also create new projects as either a sandbox or a "full" project.

Here are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find lots more contributors chatting on IRC in #drupal-contribute. So, come hang out and get involved!

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

Thanks to the dedicated reviewer(s) as well.