Hi, this module is working very good !
Just today I got a strange error when reporting an account to www.stopforumspam.com as a spammer from the user/#/spambot page.
The user went blocked. but an error message said that it wasn't able to report it as a spammer. Following the log:

Error reporting account: http://www.stopforumspam.com/add.php?email=gadgetertp%40gmail.com&userna......&ip_addr=89.178.214.225
stdClass Object
(
[request] => GET /add.php?email=gadgetertp%40gmail.com&username=GaDGfaw&api_key=...&ip_addr=89.178.214.225 HTTP/1.0
Host: www.stopforumspam.com
User-Agent: Drupal (+http://drupal.org/)

[data] =>
data submitted successfully

Message:

[protocol] => HTTP/1.1
[status_message] => OK
[headers] => Array
(
[Server] => nginx
[Date] => Sat, 26 Nov 2011 07:48:57 GMT
[Content-Type] => text/html
[Connection] => close
[Vary] => Accept-Encoding
[X-Powered-By] => PHP/5.3.6-13ubuntu3.2
)

[code] => 200
)

Comments

bengtan’s picture

bengtan commented

Hi,

Hmmm ... strange.

The module has reported an error, but looking at your posted data, I can't see why it would report an error.

Does this message still occur? If it's only a one-off, I'd like to write it off as a glitch.

Otherwise, I'll need more information ... was the reporting actually successful (ie. it was added to your "My spammer's" page at stopforumspam.com)? How do you reproduce it (if you can)?

bengtan’s picture

bengtan commented

Hi,

Oh, I worked out why its reporting an error.

The module checks for the string 'Data submitted successfully' in the response from stopforumspam.com.

From your posted data, the response includes 'data submitted successfully' with an lowercase 'd'. I've confirmed this is also the case at a forum I run. It looks like stopforumspam.com has changed it's behaviour slightly and this is throwing the module off.

I'll need to change the module to match the change at stopforumspam.com.

bengtan’s picture

bengtan commented
Title: "Error reporting account" even when data submitted successfully » Spurious 'Error reporting account ...' messages.
mandreato’s picture

mandreato commented
Title: Spurious 'Error reporting account ...' messages. » "Error reporting account" even when data submitted successfully

It occoured only to the last spammer who visited my site (luckily no other bad account made visit today), so I cannot say if it is just a glitch.

I also suspected that stopforumspam changed the returning message. Indeed the spammer was successfully added to "My spammer's" page.

Thanks In Advance for adapting this module to the new behaviour.

bengtan’s picture

bengtan commented
Title: "Error reporting account" even when data submitted successfully » Spurious 'Error reporting account ...' messages.
bengtan’s picture

bengtan commented
Status: Active » Fixed

Fixed and will be released in 6.x-3.1 and 7.x-1.x. Thanks for picking this up.

The commits are:

http://drupalcode.org/project/spambot.git/commit/dea6989 (6.x)
http://drupalcode.org/project/spambot.git/commit/db4ab7d (7.x)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.