I'm seeing that if I set the Custom Title to the node title of a referenced node (via a relationship), then an apostrophe in the node title is displayed in fullcalendar as its raw HTML entity code.

e.g. I have a referenced node with the title "All's Well That Ends Well". When I set this referenced node title as the Custom Title, it is shown on full calendar as All's Well That Ends Well. Setting the view to another display format, shows the reference node title correctly.

Comments

tim.plunkett’s picture

Version: 7.x-2.0-alpha7 » 7.x-2.x-dev
Status: Active » Needs review
StatusFileSize
new604 bytes

Sorry for the delay!

Can you try this patch and see if it helps?

Anonymous’s picture

I'm afraid it doesn't. With the patch it appears as
All's Well That Ends Well

tim.plunkett’s picture

Status: Needs review » Needs work

Wow, so that makes it even worse! Back to the drawing board.

tim.plunkett’s picture

Status: Needs work » Postponed (maintainer needs more info)

References is going to be deprecated in favor of http://drupal.org/project/entityreference, can you reproduce the bug with that module?

aspilicious’s picture

Can we try filter_xss ??

tim.plunkett’s picture

Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new634 bytes

Turns out there was a new method added to views recently that gives us the un-rendered title, which is what I think we want.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

Works great but needs a dependency test on views stable.
RTBC for me

tim.plunkett’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new604 bytes

It turns out this breaks the ability to rewrite fields to use a the title, which is a huge feature.

Instead, let's just run the opposite of check_plain. The plugin doesn't expect escaped HTML, so we can't give it escaped HTML.

aspilicious’s picture

Status: Needs review » Reviewed & tested by the community

:)

better, much better

tim.plunkett’s picture

Status: Reviewed & tested by the community » Fixed
tim.plunkett’s picture

As a follow-up, I just figured out what was happening.

Since the title is passed as an attribute of the link, that the plugin uses to make the event, drupal_attributes was calling check_plain on it anyway.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Anonymous’s picture

I just updated to 2.0-beta3 and all is looking great, so thanks guys.

brandenlhamilton’s picture

Version: 7.x-2.x-dev » 6.x-2.x-dev
Status: Closed (fixed) » Needs review
StatusFileSize
new739 bytes

The attached patch simply back-ports the solution in #8 for the 6.x-2.x version of this module.

christianchristensen’s picture

Status: Needs review » Reviewed & tested by the community

Looks good to me

heddn’s picture

Issue summary: View changes
Status: Reviewed & tested by the community » Closed (outdated)

Version 6.x of this module is no longer actively supported. Closing out tickets against that version. If this is still an issue in an actively supported version of this module, feel free to re-open and provide steps to reproduce the issue.