Code supplied can't work with Sagepay Server Integration

Hi,

Of the 3 SagePay modules, this one is the least developed and is not production ready yet.

I'm working on it, but in the meantime, have a look at SagePay Form and SagePay Direct.

I'll update this issue as the module work processes.

Richard

This module needed a compete rewrite to make it work with SagePay server protocol v2.23. The attached patch is a working version which is currently undergoing testing on a commerce site.

Applied that patch and can confirm that it works well. Here is a version without white-space errors:

How do I apply the patch? I've tried in Net beans, but says it cannot apply in this context.

M

in Unix systems you can do patch -p0 file.patch or git apply file.patch

We've been using this for several months now without any problems

I have applied this patch but receive an error message at sagepay transaction report: "Transaction completed but Vendor systems returned INVALID or ERROR in response to notification POST. Transaction CANCELLED by the Vendor."
same error on live and test servers.

no error messages at watchdog report.

Hi,

I have been working on a rewrite to the module for a project so I've finally been able to give it some proper attention. I'll be pushing new code up on Monday which incorporates code from the posted patch and also many other changes.

If anyone is able to test it, I'd appreciate the feedback and we can try to get to a 1.0 release.

many thanks

Richard

Hi Richard, thank you for your work.
have you pushed the new code yet? I tried to play with the most recent dev version today but still receiving this message at sagepay transaction report: "Transaction completed but Vendor systems returned INVALID or ERROR in response to notification POST. Transaction CANCELLED by the Vendor."
I've added some code from uc_sagepayserver module to your previous dev version:

$transaction->status = COMMERCE_PAYMENT_STATUS_SUCCESS;
$transaction->message = 'OK';
$status = "OK";
$reason = 'OK';
$data['Status'] = 'OK';
$data['RedirectURL'] = url('checkout/' . $order->order_id . '/payment/return/' . $order->data['payment_redirect_key']);
echo _commerce_sagepayserver_encode_response($data);
watchdog('commerce_sagepay', 'Transaction was ok for order %order_id', array('%order_id' => $order->order_id), WATCHDOG_INFO);

and

/**
 * Encode the notification response data into the appropriate format for Sagepay
 */
function _commerce_sagepayserver_encode_response($data) {
$output = '';
foreach ($data as $key => $value) {
$output .= $key . "=" . $value . "\r\n";
}
return $output;
}

and live transactions went through just fine but I am not a php programmer and not sure that it was a right approach )
another issue I see is that all discounts applied displayed as negative Item tax value at SagePay, not a big deal but confusing.

rlmumford

We've been using this for several months now without any problems

how thats possible? on live server? no errors?

Hi,

The latest -dev version is working well now and is being used in a few production sites that I am aware of.

Can you see if this is working ok for you now and I can close this issue and get an official release rolled.

many thanks

Richard

typos again