in nginx_simple_include.conf, there is a rule to allow php files from known module, it has some bug

1. It should allow for parameters in the url, like serve.php?whatever=melikeparams (remove the $)
2. Should allow files when module is in a subfolder say: "modules/contrib/ad", it only allows "modules/ad"

So line 210 has this:
location ~* /(?:modules|libraries)/(?:ad|tinybrowser|f?ckeditor|tinymce|wysiwyg_spellcheck)/.*\.php$ {

Should be something like (open to suggestions)
location ~* /(?:modules|libraries).*/(?:ad|tinybrowser|f?ckeditor|tinymce|wysiwyg_spellcheck)/.*\.php(\?.*)?$ {

I'm marking as major since it breaks functionality for some modules and it is not easily fixable if whoever is in charge has no clue about regex!

Cheers

Comments

omega8cc’s picture

Version: 6.x-1.6 » 6.x-1.x-dev
Assigned: Unassigned » omega8cc
Category: bug » feature
Priority: Major » Normal

1. In Nginx world $args, so anything after ? and the ? itself is not a part of location check so the regex is correct and supports $args properly.

2. This is rather feature request, not a bug. We already added this in the BOA variant, but the code has not been submitted to Provision yet. See: http://drupalcode.org/project/barracuda.git/blob/HEAD:/aegir/conf/nginx_...

jm.federico’s picture

Cool

HA! New lingo! "args" from now on! Cheers for that.
Thanks, copied new regex from Barracuda, thanks!

omega8cc’s picture

Status: Active » Fixed

It has been fixed a long time ago.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.