In #564106: More links pointing to custom URLs don't respect entered fragments and query parameters, there was a link_display section added. It throws undefined index errors for title, css_class, and display_comment.

CommentFileSizeAuthor
#1 views-1354084-1.patch779 bytestim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new views-1354084-1.patch779 bytes

This giant switch/case where some break, some passthrough, is very scary.
Also, $this->set_option($section, $form_state['values'][$section]); is in there a half dozen times.
Should it be refactored?

In the meantime, this seems sane.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Fixed

The makes looks fine, so committed to 7.x-3.x and 6.x-3.x

In general it would be cool to get this code in a better shape but this should probably be part of a new task.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.