Commerce Recommender

Moving from a master to a major version branch is needed.

This is your correct git clone line:
git clone http://git.drupal.org/sandbox/dwkitchen/1341616.git commerce_rec

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• commerce_rec.module
  in commerce_rec.info: It's only necessary to declare files[] if they declare a class or interface.
• commerce_rec.views_default.inc in commerce_rec.info: It's only necessary to declare files[] if they declare a class or interface.
• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  
  commerce_rec.info
  commerce_rec.install
  commerce_rec.views_default.inc
  

• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./commerce_rec.views_default.inc ./commerce_rec.info ./commerce_rec.install
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Review of the 7.x-1.x branch:

• Lines in README.txt should not exceed 80 characters, see the guidelines for in-project documentation.
• commerce_rec.module
  in commerce_rec.info: It's only necessary to declare files[] if they declare a class or interface.
• Bad line endings were found, always use unix style terminators. See http://drupal.org/coding-standards#indenting
  

  
  commerce_rec.info
  commerce_rec.install
  commerce_rec.views_default.inc
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

I'll review this tomorrow.

Went through the code, with a small delay.
Don't have experience with the Recommender API.

I see there's not a lot of code. Still, I have reservations about the sql query you are plugging into the API:

  $sql = "SELECT o.uid, p.product_id, o.created
          FROM {commerce_order} AS o
          INNER JOIN {commerce_line_item} AS l
          ON o.order_id = l.order_id
          INNER JOIN {commerce_product} as p
          ON l.line_item_label = p.sku
          WHERE l.type = 'product'
          GROUP BY o.uid, p.product_id";

You are getting the product_id by joining line_items and products tables on l.line_item_label = p.sku.
This seems very fragile. While Commerce does indeed put the SKU as the label by default, there's no guarantee that the label won't be anything else.
It was never meant to be used this way. You'll also notice that there's no index on l.line_item_label.
My advice would be to join the table of the commerce_product reference field (attached to the line_item entity) and get the product_id from there.
It does mean you assume SQL storage for Field API fields, but it's a far better approach than joining based on labels.

Nitpicks (while we're at it):

      'entity_type' => array(
          'similarity' => array('commerce_product', 'commerce_product'),
          'prediction' => array('users', 'commerce_product')
      ),

similarity and prediction are indented with 4 spaces instead of 2.

/**
 * Implements of hook_help().
 */

Should be "Implements hook_help()".

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

manual review:

• This project is too short to approve you as git vetted user. We are currently discussing how much code we need, but everything with less than 120 lines of code or less than 5 functions cannot be seriously reviewed. However, we can promote this single project manually to a full project if you wish.
• Have you contacted the recommender module maintainers via the issue queue or other channels? Why can't this module not live inside the recommender project as submodule?

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

Otherwise I think this is ready for a single project promotion.

Hey @dwkitchen, you now have full Git access. Happy hunting.

Thanks to all the reviewers!