When use option Aggregate JavaScript files, twitter.js break with error.
This patch fix error.
Please, review it and give your feedback.
thanks

CommentFileSizeAuthor
fix_twitter1.patch2.49 KBdimon4ikzp

Comments

juampynr’s picture

juampynr commented
Title: Uncaught TypeError: Property '$' of object [object DOMWindow] is not a function » Port Twitter Post Javascript code to Drupal 7
Status: Needs review » Fixed

Hi dimon4ikzp,

Many thanks for reporting this bug and provide a patch. Actually, twitter.js file had a few bugs in it and the error you mentioned happened even with no javascript compression activated. I made a few improvements on both Drupal 6 and Drupal 7 versions:

* Added Drupal behaviours statement.
* Changed field maxlength to 150 characters.
* Fixed wrong JQuery selector to show remaining characters while typing.
* Renamed file to twitter_post.js and moved it within twitter_post submodule.

This weekend I will release a new stable version of each of them.

Many thanks.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.