Drush prints out HTML into terminal

Please provide more detail. Drupal7 tries not to print html in its errors. What code is doing thle placeholder?

Maybe we need to add strip_tags to $value in includes/batch.inc?

class DrushBatchContext extends ArrayObject {
  function offsetSet($name, $value) {
    if ($name == 'message') {
      drush_log($value, 'ok');
    }
    elseif ($name == 'error_message') {
      drush_set_error('DRUSH_BATCH_ERROR', $value);
    }
    parent::offsetSet($name, $value);
  }
}

(Only add strip_tags to the parameter $value as passed to drush_log and drush_set_error; do not perturb parent:offsetSet.)

Patch in #6 works :)

(Tested with drush up command).

committed to master. seems safe for 4.x but does not apply cleanly.

Set status.

Sounds right to me.

What if instead calling strip_tags() all the time, we used dt()?

Not going to translate arbitrary strings. Drupal doesn't do that either.

The reason I bring that up is because this looks kind of silly.

Ah, I understand. This is the same issue, but occurring in different places. I'm running into HTML being outputted when running through Drush Make's download factory. I think we have two options here...

1) drushmakehtml.patch

Stick a strip_tags() in the dt() function so that the <em> tags are removed.

2) checkplainInsteadOfEm.patch

Switch the dt() parameters to use @ instead of % so it uses check_plain() on the parameters instead of wrapping it in an em tag.

I think I prefer the #2 checkplainInsteadOfEm.patch approach more. Let's use @ instead of % for those dt() calls.

I agree that #2 is preferable.

Committed.

I still see this with Drush 5.1:

$ drush urol "administrator" --uid=2
Added the <em class="placeholder">administrator</em> role to uid <em class="placeholder">2</em>                                                                           [success]

Please use latest dev snapshot before reporting bugs. That might be fixed already. If still broken, feel free to reopen.

My mistake, I did not see that this thread was related to Drush Make. This is an issue when using core commands. I'll open another issue.