Since #1268636: Watchdog should ignore reports below the system reporting level is currently D8-only, will never make it to D6 and seems unlikely to make it to D7, the feature needs to be included within mongodb_watchdog for core versions not supporting it.

CommentFileSizeAuthor
#7 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-7-D6.patch11.49 KBfgm
#7 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-7-D7.patch14.33 KBfgm
#6 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-6-D6.patch10.59 KBfgm
#6 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-6-D7.patch13.76 KBfgm
#5 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on--D6.patch7.96 KBfgm
#3 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-in.patch8.09 KBfgm
#1 0001-Issue-1355808-Implement-watchdog-filter-on-insert.patch6.66 KBfgm

Comments

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Active » Needs review
StatusFileSize
new 0001-Issue-1355808-Implement-watchdog-filter-on-insert.patch6.66 KB

First step: unbreak the test file and make a working test case showing the goal.

Of course, this needs a working MongoDB instance on localhost, so PIFR will not accept it: this needs to be run on a dev. machine with MongoDB installed.

Status: Needs review » Needs work

The last submitted patch, 0001-Issue-1355808-Implement-watchdog-filter-on-insert.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Title: Implements watchdog filter-on-insert » Implement watchdog filter-on-insert in mongodb_watchdog
Status: Needs work » Needs review
StatusFileSize
new 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-in.patch8.09 KB

And now complete with working code and test polishing.

Status: Needs review » Needs work

The last submitted patch, 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-in.patch, failed testing.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on--D6.patch7.96 KB

And D6 backport with workaround for core issue #904994: [Regression] Watchdog should always use replaceable argument.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-6-D7.patch13.76 KB
new 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-6-D6.patch10.59 KB

D6 and D7 versions rerolled with minor improvements.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
StatusFileSize
new 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-7-D7.patch14.33 KB
new 0001-Issue-1355808-by-fgm-Implement-watchdog-filter-on-7-D6.patch11.49 KB

Added documentation in the README.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented
Status: Needs work » Fixed

Committed to D6 and D7 branches, since there is no way PIFR can provide tests and they pass locally.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.