Closed (fixed)
Project:
Metatag
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
29 Nov 2011 at 16:35 UTC
Updated:
26 Oct 2012 at 00:47 UTC
Jump to comment: Most recent file
It is not totally clear what Edit Meta Tags means.
So if
/**
* Implements hook_permisson().
*/
function metatag_permission() {
$permissions['administer meta tags'] = array(
'title' => t('Administer meta tags.'),
'restrict access' => TRUE,
);
$permissions['edit meta tags'] = array(
'title' => t('Edit meta tags.'),
);
return $permissions;
}
was changed to below or something like it (minus the asterisks) it may make it easier to quickly grasp that setting?
/**
* Implements hook_permisson().
*/
function metatag_permission() {
$permissions['administer meta tags'] = array(
'title' => t('Administer meta tags.'),
'restrict access' => TRUE,
);
$permissions['edit meta tags'] = array(
'title' => t('Edit meta tags ****per Entity creation ie Node, Tag etc.****'),
);
return $permissions;
}
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | metatag-n1355990-5.patch | 816 bytes | damienmckenna |
| #2 | metatag-n1355990-2.patch | 413 bytes | damienmckenna |
Comments
Comment #1
marcoka commentedComment #2
damienmckennaThanks for pointing this out, and you are quite correct, the current description is a bit confusing.
A small note about issue queue etiquette: please don't change an issue's status to "needs review" until there is an actually patch file to review, like this one :)
Comment #3
damienmckennaThis will do for now. Committed. Thanks for pointing this out.
Comment #4
dave reidThis should go in the description of the permission, not the title. Titles should be short but efficient as possible.
Comment #5
damienmckennaAh. Sorry for forgetting about the 'description' argument.
Comment #6
damienmckennaCommitted.
Comment #8
yurtboy commentedthanks!