Upgrading from 1.6 to 2.x results in the inability to save term_fields data to terms

Downgrading the priority to major, as the possibility exists that this is something on my end.

Okay, I found the problem.

In the upgrade process, we call term_fields_update_6101(), which adds a vid field to {term_fields_terms} on line 185:

// Add the 'vid' column to . This allows to easily reset the values
// when a field is removed from a specific vocabulary.
db_add_field($ret, 'term_fields_term', 'vid', array('type' => 'int', 'unsigned' => TRUE, 'not null' => TRUE), array('indexes' => array('vid' => array('vid'))));

The problem is we never assign a value for each row's vid, so every upgraded row is given a vid of 0.

In term_field.module's hook_taxonomy() implementation, on $op term insert or update, we select where to update a row based on BOTH the tid and vid (line 241):

db_query("UPDATE {term_fields_term} SET ". implode(', ', $nulls) ." WHERE tid = %d AND vid = %d", $args);

Of course, every upgraded row has a vid of 0, so this query returns no results.

The quick solution is to remove the AND vid = %d (it's not necessary anyway), but that's not a proper solution. I'll work on figuring out the best way to update each row during the upgrade process and post a patch when it's ready.

Here's a patch that runs a hook_update_N() function updating each row in {term_fields_term}