Closed (fixed)
Project:
Signup
Version:
5.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
12 Apr 2007 at 05:54 UTC
Updated:
30 Apr 2007 at 18:05 UTC
since i was the one who suggested the current approach, and it's wrong, i figured it was my resposibility to provide the fix... ;)
basically, Drupal.jsEnabled should be called before _any_ javascript is run. $() creates a jquery object, so that has to go inside a jsEnabled check. and according to steven:
UnConeD: hunmonk: the only exception is function definitions actually
UnConeD: hunmonk: because they don't actually run code
UnConeD: so Drupal.foobar = function () { .. } is allowed outside
patch also applies cleanly to HEAD. i didn't test it on an install, so you might want to do a quick test before committing.
| Comment | File | Size | Author |
|---|---|---|---|
| signup_js_killswitch.patch | 503 bytes | hunmonk |
Comments
Comment #1
dwwcool, thanks. tested and everything still seems to work fine.
Comment #2
hunmonk commentedcommitted to 5 and HEAD.
Comment #3
(not verified) commented