Choose between light and dark color scheme.

CommentFileSizeAuthor
#2 0001-change-the-color-scheme-of-the-comments-in-the-modul.patch2.05 KBjackread
0001-New-Feature-Choose-comments-color-scheme.patch1.86 KBjackread

Comments

wmostrey’s picture

wmostrey commented
Status: Active » Needs work

This line looks like it should add a string default (most likely: 'light') instead of an empty array:

+ $style = variable_get('facebook_comments_style', array());

I committed your other patch so this would need a reroll anyway. Other than that, this will be good to go.

jackread’s picture

jackread commented
StatusFileSize
new 0001-change-the-color-scheme-of-the-comments-in-the-modul.patch2.05 KB

ok this is a new patch with your suggested change.

wmostrey’s picture

wmostrey commented
Status: Needs work » Fixed

I committed this change based on your patch, with a couple of changes and fixes. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.