While trying to add Canadian Support to this module, I came across a spelling error on line 87
$shipfrom_address->addChild('CountryCode', variable_get('commerce_ups_county_code', ''));
Should Read
$shipfrom_address->addChild('CountryCode', variable_get('commerce_ups_country_code', ''));
country is spelled county
This is fine with US shipping rates as the default country in the UPS API is the US and if the field is blank then USA is used.
However, with a canadian shipment, this spelling mistake returns nothing; leaving UPS API with an unknown address.
I thought this might want to be updated in the next release.
as a side note, if there is some interest in making a patch to allow Canadian support I can share what I have done.
thanks for a great module!
Cheers
Chris
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | critical_error_in_commerce_ups_xml_inc-1356546-1.patch | 879 bytes | albert volkman |
Comments
Comment #1
albert volkman commented"country" misspelling fixed.
Comment #2
andrew m riley commentedThis has been committed to the 7.x-1.x branch.