Let's add a theming example for Drupal 6.

CommentFileSizeAuthor
#12 theming-example-1356556-12.patch6.24 KBnadavoid
#8 theming-example-1356556-8.patch6.25 KBnadavoid
#1 theming-example-1356556-1.patch4.01 KBnadavoid

Comments

nadavoid’s picture

nadavoid commented
StatusFileSize
new theming-example-1356556-1.patch4.01 KB

Initial pass at a theming_example module for D6.

rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented
Status: Active » Needs review
rfay’s picture

rfay
he,him
Primary language English
Location Palisade, CO, USA
commented

This will be a great start. Things that can make it better:

* Links to d.o docs or other docs on D6 theming.
* Tests (just simple UI tests)
* It would be nice for the tpl.php to document the variables available there (that have been provided in the preprocess). That's a good pattern for people.

Does it need more depth, or is this enough?

nadavoid’s picture

nadavoid commented
Assigned: Unassigned » nadavoid
Status: Needs review » Needs work

Those are definitely good ideas. My initial thought in adding this module was that I had just worked out how the demonstrated concepts work, and I wanted to log my findings, so this module seemed like the obvious place to do that. I think there are many more things that could be demonstrated in this module, but for this patch, I'd like to keep it basic, then expand it in a future patch. The reason being I don't want to hold up this addition.

Assigning this to me, because I'd like to do it.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Still working on it, nadavoid?

nadavoid’s picture

nadavoid commented

@Mile23 It had slipped off of my attention, but I do intend to pick this back up again in the next week or two.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Thanks much! :-)

nadavoid’s picture

nadavoid commented
Status: Needs work » Needs review
StatusFileSize
new theming-example-1356556-8.patch6.25 KB

This patch should address everything Randy mentioned.

Status: Needs review » Needs work

The last submitted patch, theming-example-1356556-8.patch, failed testing.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented 
diff --git a/theming_example/theming_example.info b/theming_example/theming_example.info
deleted file mode 100644
index 4f3114d..0000000
--- a/theming_example/theming_example.info
+++ /dev/null

Uh, wot? :-)

nadavoid’s picture

nadavoid commented

gaah. I must have gotten my branches crossed. *Real* patch coming right up.

nadavoid’s picture

nadavoid commented
Status: Needs work » Needs review
StatusFileSize
new theming-example-1356556-12.patch6.24 KB

This should be better.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

Met nadavoid today at DrupalCon woo!

Retesting the patch against current d6. My wager: It will fail, since we couldn't get any tests to pass locally on D6.28.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented

#12: theming-example-1356556-12.patch queued for re-testing.

mile23’s picture

mile23
Primary language English
Location Seattle, WA
commented
Status: Needs review » Fixed

Hmm. Guess I lost the bet.

However... I think this module is complete enough to commit. If anyone wants to nitpick later, it can be as an issue.

Committed: http://drupalcode.org/project/examples.git/commit/39f2a87a2d8304601daa17...

Thanks, nadavoid. :-)

nadavoid’s picture

nadavoid commented

Woo! Thanks Paul!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.