related to this issue: http://drupal.org/node/134631

Attached is a patch that
1. implements hook_node_grants, so that the ACLs actually apply
2. improves hook_access_records to only return a grant for an acl, if it has some users associated (= node_access performance improvement, because of less entries)
3. adds another useful API function acl_get_id_by_name()

I'm currently working on the nodeaccess module to make use of the acl module. With this patch, the acl are applied correctly for me :)

CommentFileSizeAuthor
acl.patch1.61 KBfago

Comments

fago’s picture

fago
Primary language German
Location Vienna
commented

Just for completeness, here you can read more about the module I'm working on: http://groups.drupal.org/node/3620

fago’s picture

fago
Primary language German
Location Vienna
commented

committed to 5.x :)

The committed patch includes another improvement:
4. instead of returning no grants for a node of an acl without users, which ends up in full view access, we deny access to this node

andrewfn’s picture

andrewfn commented

Should this be marked fixed?
It would be very helpful to know which version of nodeaccess is compatible with this patch?

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

ahm, yes that should be fixed. -> fixed now.
the module I've linked is a modification of the nodeaccess module I did - it doesn't look like it gets into the "official" one. (read the linked issue, where you will also find the code) however perhaps I'll create a new project for my code..

dries’s picture

dries commented
Status: Fixed » Closed (fixed)