Meta tags views

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

• README.txt is missing, see the guidelines for in-project documentation.
• All text files should end in a single newline (\n). See http://drupal.org/node/318#indenting
  

  ./metatag_views.module ./metatag_views.metatag.inc
  

This automated report was generated with PAReview.sh, your friendly project application review script. Go and review some other project applications, so we can get back to yours sooner.

Source: http://ventral.org/pareview - PAReview.sh online service

Wow... I haven't tested this yet, but it's pretty crazy when you start looking for something and you find a new module which proposes to be the solution for your problem and find that it was posted for review earlier that same day...

Subscribe

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

FILE: ...al-7-pareview/sites/all/modules/pareview_temp/test_candidate/README.txt
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AFFECTING 1 LINE(S)
--------------------------------------------------------------------------------
 11 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...ites/all/modules/pareview_temp/test_candidate/metatag_views.metatag.inc
--------------------------------------------------------------------------------
FOUND 1 ERROR(S) AND 1 WARNING(S) AFFECTING 2 LINE(S)
--------------------------------------------------------------------------------
 19 | WARNING | A comma should follow the last multiline array item. Found: ')'
 25 | ERROR   | Files must end in a single new line character
--------------------------------------------------------------------------------


FILE: ...iew/sites/all/modules/pareview_temp/test_candidate/metatag_views.module
--------------------------------------------------------------------------------
FOUND 6 ERROR(S) AFFECTING 6 LINE(S)
--------------------------------------------------------------------------------
  2 | ERROR | Missing file doc comment
 10 | ERROR | Inline control structures are not allowed
 20 | ERROR | Inline control structures are not allowed
 32 | ERROR | Inline control structures are not allowed
 40 | ERROR | Inline control structures are not allowed
 43 | ERROR | Files must end in a single new line character
--------------------------------------------------------------------------------

Source: http://ventral.org/pareview - PAReview.sh online service

Manual review:
- Please check drupal coding standard http://drupal.org/coding-standards, for example http://drupal.org/coding-standards#controlstruct
if (isset($instance))
$cache = $instance;

Hi,

Very helpful module which could be really useful for me in some case.
So first, thanks for contrib.

However, I thought your module doesn't meet requierements to get a full project acces (see this post for more information: At least 120 lines and 5 functions) but your project can be still be promoted manualy by git admin as a single project.

I found some small issues with manual review of 7.x-1.x branch:

Global:

1. For each files, you also have 2 empty lines at the end of the file. Please remove one.
2. I think there is something really confusion on your module name (Meta tags views) and name used in module (metatag_views).
   The fact is that after downloading your module I obtain a folder called "meta_tags_views".

   Folder should be the same as the module name to be more clear. Also, it's a bit confusing if you want to use drush command.

.info files

• As mentioned above, modify the module name also in .info files.
• You can remove double quotes from description line.

.module

• Empty line on comment (line 5) can be removed.
• Line 6 should be ending by a ., ! or ? as every comment

I've to agree with jygastaud, this is probably not enough code to make a serious review of ribakker's skills.
-> Adding single project promotion tag.

@ribakker
Please consider coming back with a module that is a little more complex.
Or - if possible - you can try to add more functionality to this module to give us more to review.

Sorry for the delay, but you have not listed any reviews of other project applications in your issue summary as strongly recommended here: http://drupal.org/node/1011698

Review of the 7.x-1.x branch:

• Drupal Code Sniffer has found some issues with your code (please check the Drupal coding standards). See attachment.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

• project page is too short, see http://drupal.org/node/997024
• I think the module name is ok, "metatag_views" matches the parent "metatag".

But apart from that minor issues this looks ready to go for me.

I granted access based on klausi's RTBC. I think that's all that needs to be done? If not, let me know.

Thanks for your contribution, ribakker! Welcome to the community of project contributors on drupal.org.

Michelle has granted you the git vetted user role which will let you promote this to a full project and also create new projects as either sandbox or "full" projects depending on which you feel is best.

Thanks, also, for your patience with the review process. Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

As you continue to work on your module, keep in mind: Commit messages - providing history and credit and Release naming conventions.

Thanks to the dedicated reviewer(s) as well.