I'm using Drupal 5.1 with the 'normal' cache feature and I have setup two logos. One for a specific path and another one as default. If I'm authenticated, it's working properly (The first logo is displayed for the specific path and the second one for all others paths) but as a visitor, I always get the default logo. I'm using the new logo.php file (i.e. I copied it to the root directory and I modified the logo path setting accordingly).

Comments

pobster’s picture

pobster commented
Assigned: Unassigned » pobster
Priority: Normal » Critical

Bugger I wish you'd posted that this morning (well, my this morning BST time!)

Hmmm... Yes, appears to be because the flag which gets set to show the page does/ doesn't require a new random image is never unset in certain circumstances... This will effect *every* version of logotool which has this code...

...A short-term fix is to simply remove the flag code and have the module work the same way it did before:

Change this;

    case '3':
      $match = logotool_fetch_matches();
      // If there's a match, set the logo variable
      if ($match) {
        if (!variable_get('logotool_flag', '')) {
          variable_set('logotool_flag', variable_get('logotool_logo', ''));
        }
        if (module_exists('locale') && variable_get('logotool_locales', 0)) {
          global $locale;
          if (is_file(sprintf("%s/%s/%s", variable_get('logotool_folder', LT_CWD), $locale, trim($match['1'])))) {
            variable_set('logotool_logo', sprintf("%s/%s", $locale, trim($match['1'])));
          }
          else {
            variable_set('logotool_logo', trim($match['1']));
          }
        }
        else {
          variable_set('logotool_logo', trim($match['1']));
        }
      }
      else {
        if ($time || !variable_get('logotool_frequency', 0) || variable_get('logotool_flag', '')) {
          $logos = logotool_scan_dir();
          if ($time) variable_set('logotool_timestamp', time());
          if (!$time && variable_get('logotool_flag', '')) {
            variable_set('logotool_logo', variable_get('logotool_flag', ''));
          }
          else {
            variable_set('logotool_logo', substr(array_rand($logos), strlen(variable_get('logotool_folder', LT_CWD))));
            variable_set('logotool_flag', '');
          }
        }
      }
      break;
  } // end switch
} // logotool_process

To this;

    case '3':
      $match = logotool_fetch_matches();
      // If there's a match, set the logo variable
      if ($match) {
        if (module_exists('locale') && variable_get('logotool_locales', 0)) {
          global $locale;
          if (is_file(sprintf("%s/%s/%s", variable_get('logotool_folder', LT_CWD), $locale, trim($match['1'])))) {
            variable_set('logotool_logo', sprintf("%s/%s", $locale, trim($match['1'])));
          }
          else {
            variable_set('logotool_logo', trim($match['1']));
          }
        }
        else {
          variable_set('logotool_logo', trim($match['1']));
        }
      }
      else {
        if ($time || !variable_get('logotool_frequency', 0)) {
          $logos = logotool_scan_dir();
          if ($time) variable_set('logotool_timestamp', time());
          variable_set('logotool_logo', substr(array_rand($logos), strlen(variable_get('logotool_folder', LT_CWD))));
        }
      }
      break;
  } // end switch
} // logotool_process

That *should* work (untested)... Please bear with me...

Pobster

pvasener’s picture

pvasener commented

Hum... Well indeed my configuration is using case 2 not 3. BTW, I had to correct a bug changing:

    case '2':
      $match = logotool_fetch_matches();
      // If there's a match, set the logo variable
      if ($match) {
        if (module_exists('locale') && variable_get('logotool_locales', 0)) {
          global $locale;
          if (is_file(sprintf("%s/%s/%s", variable_get('logotool_folder', LT_CWD), $locale, trim($match['1'])))) {
            variable_set('logotool_logo', sprintf("%s/%s", $locale, trim($match['1'])));
          } else {
            variable_set('logotool_logo', trim($match['1']));
          }
        }
      }
      // Else set the logo to default
      else {
        variable_set('logotool_logo', variable_get('logotool_path', 'misc/druplicon.png'));
      }
      break;

to this:

    case '2':
      $match = logotool_fetch_matches();
      // If there's a match, set the logo variable
      if ($match) {
        if (module_exists('locale') && variable_get('logotool_locales', 0)) {
          global $locale;
          if (is_file(sprintf("%s/%s/%s", variable_get('logotool_folder', LT_CWD), $locale, trim($match['1'])))) {
            variable_set('logotool_logo', sprintf("%s/%s", $locale, trim($match['1'])));
          } else {
            variable_set('logotool_logo', trim($match['1']));
          }
        } else {
          variable_set('logotool_logo', trim($match['1']));
        }
      }
      // Else set the logo to default
      else {
        variable_set('logotool_logo', variable_get('logotool_path', 'misc/druplicon.png'));
      }
      break;

Because I don't use the 'locale' module and so, the logotool_logo variable was not set properly.

However, I still have the same problem. It's working fine when I'm authenticated but I have the same behaviour when not.

pobster’s picture

pobster commented

Well spotted! Hmmmm I'm stumped about the caching issue now... Really thought I'd had it then... I assume it works just fine when you disable the cache right?

Pobster

pvasener’s picture

pvasener commented

Yes, it's working properly with no cache.

pvasener’s picture

pvasener commented
Version: 5.x-2.x-dev » 5.x-2.1

BTW, I'm working with version 5.x-2.1 now.

pobster’s picture

pobster commented

Thanks ;o)

I think my only option is to move all the random code into logo.php although being completely honest... I don't know how I'm going to do it... You can't access $_GET['q'] that way as logo.php is accessed indirectly.

...I think for the time being your best option is to disable the cache while I have a think about a plan of action.

Thanks,

Pobster

pvasener’s picture

pvasener commented

Ok, no big deal for me to disable the cache for the moment anyway. Good luck for your plan of action, I will try to have a look at the code on my side too.

pobster’s picture

pobster commented

Excellent thanks! :o)

Pobster

pobster’s picture

pobster commented
Status: Active » Fixed

Okay fixed for both 4.7 and 5.x as of today (version 4.7-2.0 and 5.x-2.3) - I'm closing this thread but please feel free to reopen it if you have problems. One problem you may have is that in your system table logotool requires bootstrap to be '1' (without the quotes!) This happens automatically when you simply navigate to the /modules page (so I'm told, but perhaps you need to click submit as well - not sure about that...) but if it doesn't then either reinstall logotool (remove the system entry before installing again) or simply update the system table yourself.

Thanks,

Pobster

pobster’s picture

pobster commented
Status: Fixed » Closed (fixed)