Fixes a typo while setting the body
Uses git show to get the message

CommentFileSizeAuthor
#3 fserver_body.patch1.42 KBattiks
fserver_body.patch1.59 KBattiks

Comments

eugenmayer’s picture

Status: Needs review » Needs work

that patch looks broken to the bones, you might have a encoding problem. Could you please reapply it?

attiks’s picture

No idea what happened, I'll try again later today.

attiks’s picture

Status: Needs work » Needs review
StatusFileSize
new1.42 KB

Mystery solved, i used git df (alias for colored diff) to create the patch, new one attached

eugenmayer’s picture

thank you.

well, that git show command is yet not very known to me. We have to clear out when it got introduced and what git versions include it. Just right after it we have to consider which distributions would be affected by this, as the fserver will run on linux server mostly, ubunut / debian servers ( current stable ) should work, at least it should be our scope.

attiks’s picture

As far as i can tell it has always been there.

eugenmayer’s picture

its there on :
- OSX-Lion ( homebrew git and normal )
- Debian 5.0 stable

Anybody has a 10.04 Ubuntu online to test this. Then we can actually just take one in. Thnkas

eugenmayer’s picture

applied for 6.x-1.2 in 957e4d5

diff --git a/fserver.drush.inc b/fserver.drush.inc
index 4f317e0..6741e43 100644
--- a/fserver.drush.inc
+++ b/fserver.drush.inc
@@ -243,8 +243,7 @@ class FserverProject {
         $node->created = !empty($tag['timestamp']) ? $tag['timestamp'] : time();
         $node->uid = $this->node->uid;
         $node->title = "{$this->name} {$tag_id}";
-        $node->body = !empty($tag['message']) ? $tag['message'] : '';
-
+       $node->body = array(LANGUAGE_NONE => array(0 => array('value' => !empty($tag['message']) ? $tag['message'] : '')));
         $node->field_fserver_file = array(0 => (array) $file);
         $node->field_fserver_project = array(0 => array('nid' => $this->node->nid));
         $node->field_fserver_api = array(0 => array('value' => $tag['core']));
@@ -378,10 +377,10 @@ class FserverProject_git {
       drush_op('drush_shell_exec', "git --git-dir={$this->path}/.git log -1 --pretty=format:%%ct {$vc}");
       $info = drush_shell_exec_output();
       $tag['timestamp'] = $info[0];
-      drush_op('drush_shell_exec', "git --git-dir={$this->path}/.git tag -l {$vc} -n 1000");
+      drush_op('drush_shell_exec', "git --git-dir={$this->path}/.git --work-tree={$this->path} show --format=%%b {$vc} -n 1001");
       $info = drush_shell_exec_output();
       // Remove the tag from the first line of the message:
-      $info[0] = str_replace($vc, '', $info[0]);
+      $info = array_slice($info, 2);
       $tag['message'] = implode("\n", $info);
       return $tag;
     }
eugenmayer’s picture

Status: Needs review » Postponed

for now, postponing all all D7 issues, as the branch seems unmaintained by the initial author. PLease suggest using D6 rather for now