Can you make this module locate the fitvids .js in the libraries or scripts folder? Updating it will lose the framework every time.

CommentFileSizeAuthor
#3 movetolibraries-1357688-3.patch4.96 KBwroxbox

Comments

derekahmedzai’s picture

Good idea. Probably best if it's implemented as a library.

dddbbb’s picture

+1 This seems to be the standard for all the right reasons.

wroxbox’s picture

StatusFileSize
new4.96 KB

Here is the patch

You need to enable libraries module to use it.

dddbbb’s picture

Patch in #3 fails to patch fitvids.info for me:

patching file fitvids.info
Hunk #1 FAILED at 1.
1 out of 1 hunk FAILED -- saving rejects to file fitvids.info.rej

Not sure why.

wroxbox’s picture

Oh - I think it is because of the drupal.org packaging

; Information added by drupal.org packaging script on 2011-11-08
version = "7.x-1.3"
core = "7.x"
project = "fitvids"
datestamp = "1320745532"

I'll check to make correct patch.

wroxbox’s picture

rm -rf fitvids/
git clone --branch 7.x-1.3 http://git.drupal.org/project/fitvids.git
cd fitvids/
curl -O http://drupal.org/files/movetolibraries-1357688-3.patch

patch < movetolibraries-1357688-3.patch 
patching file fitvids.info
patching file fitvids.install
patching file fitvids.module
derekahmedzai’s picture

Thanks for the patch.

danny englander’s picture

I tried the patch using:

git apply -v movetolibraries-1357688-3.patch

... but got this error, not sure what this means.

error: patch failed: fitvids.info:1
error: fitvids.info: patch does not apply
Checking patch fitvids.install...
warning: fitvids.install has type 100755, expected 100644
Checking patch fitvids.module...
warning: fitvids.module has type 100755, expected 100644

Edit: I tried the steps in #6 and that worked.

danny englander’s picture

Just to clarify, I put jquery.fitvids.js in /sites/all/librararies/fitvids/jquery.fitvids.js -- it seems to work that way, not sure if a sub directory is ok but I prefer not to have loose files at /sites/all/libraries/

derekahmedzai’s picture

The lastest release locates the script in the /sites/all/libraries//fitvids folder

derekahmedzai’s picture

Status: Active » Closed (fixed)

Marking this as closed.