Closed (fixed)
Project:
Field Group
Version:
7.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
1 Dec 2011 at 17:51 UTC
Updated:
15 Oct 2014 at 21:26 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
Stalski commentedA patch would be very welcome! Thx in advance
Comment #2
nils.destoop commentedCan you provide me access to your site?
Comment #3
nils.destoop commentedAs jquery.js also give warnings. I think something is wrong with your installation.
Comment #4
isagarjadhav commentedI am also facing similar issue. Not able to trace exact line of error though. after disabling field group module everything works fine.
P.S - I have update my JQuery version using jquery update module.
Need urgent fix for this.
Comment #5
Vote_Sizing_Steve commentedI don't have the time to go through my connected modules to disable the field group module, but can offer that I get this error only for unauthenticated users (http://ivotesize.com/en/node/add/ivotesize-survey) - signed in users get all the js to work.
Comment #6
nils.destoop commentedWhere you able to fix it? I don't see any js errors on the survey form.
Comment #7
Stalski commentedWe really need more information to get into this. A simple clean drupal with a feature of some kind is good enough, we need to reproduce it.
Can you also check if it might be fixed in the dev snapshot?
Comment #8
pianomansam commentedBackground
I recently ran into a similar situation, with the same exact JavaScript error. Using Chrome developer tools (http://cl.ly/image/0n0l102S0H2j), I was able to trace the issue back the the collapsible setting on my fieldset. I went and looked at the settings for that fieldset, and noticed that this particular fieldset had no label. When I added a label for it, the error went away.
Summary
This issue (at least for me) is the result of having a collapsible fieldset without a label.
Recommendation
Make a label required if a fieldset is collapsible or collapsed, since this functionality requires a label to be present.
Comment #9
lendudeproblem for me arose when going to an URL with a multipage fieldgroup where de URL had a trailing # and nothing behind the # (so an URL for jump-to-top)
The following code was the problem (line 57 in multipage.js):
window.location.hash would return just a #, and jQuery will get called with $('#'), throwing an error
so for me the fix is adding an extra check
Don't know if this was the issue for others, but this is what caused this error for me
Len
Comment #10
Stalski commentedThe problem in #8 can not easily be fixed as the required property should run with server side which we don't have in "onchange" events in the configuration form. We might solve it with javascript but I would need to look into that to add some js functionality.
I solved the problem by adding a description and the possibility to do so. It simple suggest you need a title for collapisble elements.
The second problem is actually a good suggestion. This should not be possible indeed. Committed that as well.
thx for the report.
Comment #11
pianomansam commentedStalski, I'm slightly confused what you fixed and what is unfixable in your mind. The solution I propose in #8 is a server side validation of the fieldset settings, ensuring that if a fieldset is set to collapsible it also has a title.
Comment #12
pjcdawkins commented@Stalski, I don't understand what fix you committed, because the diff is 112KB - huge and unreadable.
http://drupalcode.org/project/field_group.git/commitdiff/51c972aebbd53e0...
Comment #14
pianomansam commentedStill looking for details from Stalski, therefore this still needs review...
Comment #15
tobiasbThe changes without Line-endings changes:
I added a patch which changes all CRLF to LF. Windows user should run this command: git config --global core.autocrlf true.
Comment #17
tobiasbNow without filemode changes.
Comment #18
tobiasbComment #20
tobiasbOk just change all CRLF to LF. Thx ;-)
Comment #21
pianomansam commented@tobiasb, what is your patch attempting to do?
Comment #22
tobiasb@pianomansam
It changes all CRLF to LF, and some whitespace, but testbot do not love it. ;-)
Comment #23
oushen commentedComment #25
oushen commentedComment #28
oushen commentedNeed remove some chars from url hash before use it in jQuery.
Comment #29
pianomansam commented@agpsoftdev what are you attempting to do with this patch?
Comment #30
oushen commented@pianomansam
patch replace
by
Comment #31
nils.destoop commentedOk, i see why you are doing this. To make sure no wrong formatted selectors are used. Committed it to dev.
Comment #35
nils.destoop commented