I had to make several tweaks to get projects up and running far enough to test security releases. It hasn't been excercised much lately and has coderotted a bit.

CommentFileSizeAuthor
#2 1358602-fix-release-issues-in-profile.patch2.32 KBbdragon

Comments

dww’s picture

dww
we/he/they
commented
Status: Active » Postponed (maintainer needs more info)

True, but can you be more specific? ;) It's hard to fix "random lossage".

Thanks,
-Derek

bdragon’s picture

bdragon commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new 1358602-fix-release-issues-in-profile.patch2.32 KB

Patch attached.

In addition to this, some of the project stuff now requires solr, so I have the following running locally but would like advice as to whether or not we want everyone to be installing solr (I happened to have a solr server running already so it "just worked" for me...)

Since going to /project downright crashes without enabling the solr stuff, it is probabaly a good idea to force them to be enabled....

diff --git a/drupalorg_testing.profile b/drupalorg_testing.profile
index 690d903..023096f 100644
--- a/drupalorg_testing.profile
+++ b/drupalorg_testing.profile
@@ -103,6 +103,9 @@ function drupalorg_testing_profile_modules() {
     // Repository authentication-related modules.
     'sshkey', 'multiple_email', 'versioncontrol_git_repo_manager', 'drupal_queue', 'waiting_queue',
 
+    // Apache solr.
+    'apachesolr', 'apachesolr_search', 'apachesolr_multisitesearch', 'project_solr',
+
     // Custom modules.
     'drupalorg', 'drupalorg_crosssite', 'drupalorg_git_gateway', 'drupalorg_project',
bdragon’s picture

bdragon commented

dww: I was allocating an issue nid for use in my commit message, sorry I was not more clear about that ;)

dww’s picture

dww
we/he/they
commented
Status: Needs review » Reviewed & tested by the community

Ahh, basically you're just working around the limitations in project_release until #642106: Add native support in project_release for a "Release type" vocabulary and #642110: Add native support in project_release for a "Security update" term are done. I wouldn't mind code comments to that effect before commit, but otherwise, looks fine to me. I haven't tested, but assuming it works (and I trust you), please go for it.

Re solr: let's move that debate to a totally separate issue please. I have strong concerns about that, but I'd rather not debate them here. ;)

Thanks!
-Derek

bdragon’s picture

bdragon commented
Status: Reviewed & tested by the community » Fixed

Agreed on all counts.

Added references to the issues you mentioned. Committed.

http://drupalcode.org/project/drupalorg_testing.git/commit/efba4bb970346...

bdragon’s picture

bdragon commented

solr concerns split off to #1358648: Enabling solr is necessary to avoid crashes in some places.

dww’s picture

dww
we/he/they
commented

Yay, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.