dialog_loading calls dialog_display with an incorrect value for the ajax parameter, leading to js errors in attach functions

The dialog_loading command (Drupal.ajax.prototype.commands.dialog_loading) that is called to insert a loading throbber calls dialog_display (Drupal.ajax.prototype.commands.dialog_display). When calling the function, it passes in this as the ajax parameter.

/**
 * Command to open a loading dialog.
 */
Drupal.ajax.prototype.commands.dialog_loading = function(ajax, response, status) {
  Drupal.ajax.prototype.commands.dialog_display(this, {
    content: Drupal.theme('DialogThrobber'),
    title: Drupal.t('Loading...')
  });
};

In the context of the function call, this refers to Drupal.ajax.prototype.commands. In dialog_display, a settings variable is created and passed to Drupal.attachBehaviors.

// Apply any settings from the returned JSON if available.
var settings = response.settings || ajax.settings || Drupal.settings;
// Process any other behaviors on the content, and display the dialog box.
Drupal.attachBehaviors(new_content, settings);

response.settings is undefined, but ajax.settings is defined because ajax refers to Drupal.ajax.prototype.commands and Drupal.ajax.prototype.commands.settings is defined as a function in ajax.js.

/**
   * Command to set the settings that will be used for other commands in this response.
   */
  settings: function (ajax, response, status) {
    if (response.merge) {
      $.extend(true, Drupal.settings, response.settings);
    }
    else {
      ajax.settings = response.settings;
    }
  },

So when the attach functions of modules are called, the settings parameter they receive is a function, not an object, as shown here in the contributed extlink module:
https://skitch.com/jesse.beach/gpymr/developer-tools-http-provideotest.w...